<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118881/">https://git.reviewboard.kde.org/r/118881/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 30th, 2014, 7:21 a.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@KDevelop team: Opinions?</pre>
</blockquote>
<p>On June 30th, 2014, 11:32 a.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd personally prefer if we could keep (part of) the current code around... Personally, I think the contents of the Kate status bar are completely overkill and contain far too many action one rarely has to look at. Esp. in split view, this will look horribly cluttered.
But I can completely understand that the information is crucial for those that use the VI mode. And probably for people who work on foreign code where they need to change the indentation or mode and stuff regularly.
So could we maybe get this in, with the ability to configure this? What to others think? I'm open for the discussion here.</pre>
</blockquote>
<p>On June 30th, 2014, 12:57 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">TBH I'm not a big fan of the status bar either, we're losing some nice vertical space.
On the other hand, I think we want to re-think parts of the UI for kdev5, so I'd suggest to have this merged and reviewed with the rest of the UI. For starters, having a way to show/hide would be enough I'd say.</pre>
</blockquote>
<p>On June 30th, 2014, 1:22 p.m. UTC, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In the past, we did show a status bar only when VI mode is on. Why not keep it like this?</pre>
</blockquote>
<p>On June 30th, 2014, 4:11 p.m. UTC, <b>Miquel Sabaté Solà</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree with Sven. As a vi-mode user myself I appreciate that there is status bar when Vi mode is on (and no, the shape of the cursor is not enough :P). Besides vi, I honestly think that this new status bar is a bit overkill (e.g. I've never had to change the encoding of a document in a KDevelop project).</pre>
</blockquote>
<p>On June 30th, 2014, 4:14 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe we could have something like "only show it when Control is pressed", so one can still interact with it. The problem being, that when pressing shortcuts, things would flash down there.</pre>
</blockquote>
<p>On June 30th, 2014, 4:33 p.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Okay. I think after hearing some opinions we come to the following conclusion(s):
- We do not want to force the status bar on users
=> We add an action: Settings -> [ ] Show/Hide status bar (similar to what Kate does)
- Personally (and I think others agree) I'd still like to see line/column information even with the status bar disabled
=> Keep the old code around that shows that information in the upper right corner. Only hide it in case the status bar is visible.
That both satisfies VI-input users, users that need to change encoding/etc. often and users with limited vspace.
If there are no objections I'm going to implement that soonish.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@Kevin: so if I have the status bar hidden, will it still show me the info from vi-mode? (as the current status bar does)</pre>
<br />
<p>- Miquel</p>
<br />
<p>On June 22nd, 2014, 4:03 p.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Aleix Pol Gonzalez.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated June 22, 2014, 4:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port to new Kate status bar
Drop the custom status label in the upper right corner</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>sublime/container.cpp <span style="color: grey">(eded49f0fc16f56f62e96f65c8c3ae44818cd2ed)</span></li>
<li>shell/uicontroller.cpp <span style="color: grey">(188f26c7e03145eaaa852071d68a984a434eafe2)</span></li>
<li>shell/textdocument.cpp <span style="color: grey">(dcc7c9cb35901bf741dc618e4d620dd12a0433d1)</span></li>
<li>shell/textdocument.h <span style="color: grey">(26f4ba8462e4d5f466f82b2b630ff79f83c85066)</span></li>
<li>shell/CMakeLists.txt <span style="color: grey">(61205a6fc0679f92a0f21fad29bd6c719238a409)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118881/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/25bde517-bc8f-4ed6-a4c6-f2c7e14f5a13__kdevelop-editorview-before.png">kdevelop-editorview-before.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/0707d702-2a76-41e5-8dc1-10aa85dbbd35__kdevelop-editorview-after.png">kdevelop-editorview-after.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>