<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119042/">https://git.reviewboard.kde.org/r/119042/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Denis Steckelmacher.</div>
<p style="color: grey;"><i>Updated June 30, 2014, 6:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-qmljs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In order not to have two different kinds of "helper widgets" (widgets that pop up when the cursor is over a QML property), QML ones and C++ ones, this patch removes the C++ color picker widget and replaces it with a pure QML implementation of it. The QML widget looks very much like the C++ one (and behaves a bit better, for instance it is always in sync with the value displayed in the source code), and is quite a bit smaller than the code it replaces.
Two features are removed by this patch, though:
* Colors are not highlighted everywhere, but only when they are used as property values. The special highlighting of colors has also been removed. I hope this feature was not too important, but I like that everything behaves in the same way (and it allowed me to remove many lines of code)
* Named colors are temporarily not supported anymore. If the user places the cursor over a named color (like "red"), the color picker widget will not recognize it and will show a black color. This comes from the fact that there is no way of getting the red, green and blue components of a color in QML, so I cannot just let QColor parse the name and then get the red, green and blue components. The parsing has to be done by hand, and currently only recognizes #rrggbbaa and #rrggbb formats (#rgba and #rgb should be easy to add if needed).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The widget is properly shown for "color" properties, and displays the color that was already present in the source code. Modifying the hue, value or luminosity of the color works as expected, and the correct color is written in the source code.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(036ec6f)</span></li>
<li>kdevqmljsplugin.h <span style="color: grey">(d1afff5)</span></li>
<li>kdevqmljsplugin.cpp <span style="color: grey">(3bf0145)</span></li>
<li>navigation/colorchooser.h <span style="color: grey">(1fa6e32)</span></li>
<li>navigation/colorchooser.cpp <span style="color: grey">(e17b18a)</span></li>
<li>navigation/propertypreviewwidget.cpp <span style="color: grey">(083ab65)</span></li>
<li>navigation/propertywidgets/ColorPicker.qml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119042/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>