<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118918/">https://git.reviewboard.kde.org/r/118918/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks, I think that makes sense.</pre>
<br />
<p>- Sven Brauch</p>
<br />
<p>On June 24th, 2014, 1:46 p.m. UTC, Denis Steckelmacher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Denis Steckelmacher.</div>
<p style="color: grey;"><i>Updated June 24, 2014, 1:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-qmljs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The QML language contains several built-in types, listed on this page: http://qt-project.org/doc/qt-5/qtqml-typesystem-basictypes.html. These types are not declared inside any module, so this patch adds a "built-in" module that declares these types.
Because most of the QML built-in types also exist in a C++ version (rect = QRect, Font = QFont, etc), this patch also adds a small translation layer between the C++ type names and the QML type names. This way, QML modules (that use the C++ names) can declares properties that will end up having the right type. A property declared of type "QRect" will have the type "rect", and all the attributes expected by the user.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A new code-completion unit test has been added. It ensures that typing "font." in a QML component having a font property of type Font displays the properties of QFont. The unit tests don't test all the type names and all the attributes of the types (it would be huge), but Font is the most interesting type.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>qmlplugins/builtins_1.0.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/files/test.qml <span style="color: grey">(a36cfdb)</span></li>
<li>qmlplugins/QtQuick_2.0.qml <span style="color: grey">(6d20f7a)</span></li>
<li>qmlplugins/QtQuick_1.0.qml <span style="color: grey">(50c08b9)</span></li>
<li>codecompletion/tests/qmlcompletiontest.cpp <span style="color: grey">(e129b09)</span></li>
<li>duchain/declarationbuilder.cpp <span style="color: grey">(aab8aeb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118918/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>