<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118881/">https://git.reviewboard.kde.org/r/118881/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 22nd, 2014, 5:07 p.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is the status bar always shown? I don't like how much space it requires... still - better than no status bar at all for the VI people, I guess...</pre>
</blockquote>
<p>On June 22nd, 2014, 7:29 p.m. UTC, <b>Dominik Haumann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Milian, search for "statusbar" at http://api.kde.org/frameworks-api/frameworks5-apidocs/ktexteditor/html/kte_port_to_5.html
In my opinion, you should try the default status bar for KF5. If it turns out to be a problem, you can still change it.
Btw, when you show the command line or any other view bar on the bottom (search, goto, ...), the status bar is hidden. So at least here, we have a good tradeoff.</pre>
</blockquote>
<p>On June 22nd, 2014, 8:22 p.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, I don't like the duplicate information (line, column) in the view. Maybe it makes sense if I revert most of the changes, but only show the information in the upper right corner in case the status bar is disabled. I'll add an action to show/hide the status bar then.
Being able to remove around 200 LOC of duplicate functionality just got me a bit overeager. I agree, that for normal use-cases the status bar is a bit too much.
@Milian: Regarding VI mode: The command-mode edit line still shows up even if the status bar is hidden. So it's not a big issue, I think. You can deduce being either in insert or visual by looking at the cursor style.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's why I'd propose to remove the line/column info next to the tabbar in KDevelop, especially since it's a rather non-standard location :-)
If you can remove 200 slocs this way, you have 200 slocs less to maintain. The status bar now also shows the highlighting mode and indentation settings. So that's also a nice addition you get for free. But of course, can can also disable it and keep your own implementation.</pre>
<br />
<p>- Dominik</p>
<br />
<p>On June 22nd, 2014, 4:03 p.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Aleix Pol Gonzalez.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated June 22, 2014, 4:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port to new Kate status bar
Drop the custom status label in the upper right corner</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>sublime/container.cpp <span style="color: grey">(eded49f0fc16f56f62e96f65c8c3ae44818cd2ed)</span></li>
<li>shell/uicontroller.cpp <span style="color: grey">(188f26c7e03145eaaa852071d68a984a434eafe2)</span></li>
<li>shell/textdocument.cpp <span style="color: grey">(dcc7c9cb35901bf741dc618e4d620dd12a0433d1)</span></li>
<li>shell/textdocument.h <span style="color: grey">(26f4ba8462e4d5f466f82b2b630ff79f83c85066)</span></li>
<li>shell/CMakeLists.txt <span style="color: grey">(61205a6fc0679f92a0f21fad29bd6c719238a409)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118881/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/25bde517-bc8f-4ed6-a4c6-f2c7e14f5a13__kdevelop-editorview-before.png">kdevelop-editorview-before.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/0707d702-2a76-41e5-8dc1-10aa85dbbd35__kdevelop-editorview-after.png">kdevelop-editorview-after.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>