<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118819/">https://git.reviewboard.kde.org/r/118819/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 18th, 2014, 9:59 p.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118819/diff/1/?file=282438#file282438line208" style="color: black; font-weight: bold; text-decoration: underline;">shell/assistantpopup.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QRect AssistantPopup::textWidgetGeometry(KTextEditor::View *view) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">170</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_view</span><span class="o">-></span><span class="n">setFocus</span><span class="p">();</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">207</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_view</span><span class="o">-></span><span class="n">setFocus</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">is this still required?</pre>
</blockquote>
<p>On June 19th, 2014, 9:29 a.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bah. Review board ate this comment.
So, the problem is that I'm not getting key press events for Alt+1 in the event filter for example. I'm not exactly sure why. I'd vote for getting this in as an initial version, though. We can investigate later if we can get rid off the focus switching altogether.
Maybe Sven also has some input regarding the missing key press event(?)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, if in the event filter you set focus to the widget after Alt gets pressed, then the event filter won't get the second one ("number key pressed") event, because the event filter is called for events on the text view and the focus is on the assistant now. I guess that's the reason?</pre>
<br />
<p>- Sven</p>
<br />
<p>On June 18th, 2014, 9:44 p.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Sven Brauch.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated June 18, 2014, 9:44 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Simplify AssistantPopup related code
Get rid off most JS logic inside QML, make it a lot more declarative.
I'm not sure if I've fixed the losing-focus bug, but I cannot reproduce
it anymore.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/assistantpopup.qml <span style="color: grey">(69ccc2f9f833567e70406e04bae040392ae3f961)</span></li>
<li>shell/assistantpopup.cpp <span style="color: grey">(1f3ff012a51dbab6f1d0c75149e3cf712f1ec449)</span></li>
<li>shell/assistantpopup.h <span style="color: grey">(475cc37c5b205d213adec7fb03c71e5a81f05749)</span></li>
<li>shell/AssistantButton.qml <span style="color: grey">(ac3d27bb6eee21a99a04005b62a3a3ef5d5c1930)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118819/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>