<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118819/">https://git.reviewboard.kde.org/r/118819/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Much red, very nice ;)
I wonder though what happened to various features, does it still work as before? Esp. no repeated animations on updates and coloring?
Anyways, if this indeed fixes the focus issue, I'm all for it -- that's by far the most important thing right now.</pre>
<br />
<p>- Sven Brauch</p>
<br />
<p>On June 18th, 2014, 9:44 p.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Sven Brauch.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated June 18, 2014, 9:44 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Simplify AssistantPopup related code
Get rid off most JS logic inside QML, make it a lot more declarative.
I'm not sure if I've fixed the losing-focus bug, but I cannot reproduce
it anymore.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/assistantpopup.qml <span style="color: grey">(69ccc2f9f833567e70406e04bae040392ae3f961)</span></li>
<li>shell/assistantpopup.cpp <span style="color: grey">(1f3ff012a51dbab6f1d0c75149e3cf712f1ec449)</span></li>
<li>shell/assistantpopup.h <span style="color: grey">(475cc37c5b205d213adec7fb03c71e5a81f05749)</span></li>
<li>shell/AssistantButton.qml <span style="color: grey">(ac3d27bb6eee21a99a04005b62a3a3ef5d5c1930)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118819/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>