<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118627/">https://git.reviewboard.kde.org/r/118627/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Aleix Pol Gonzalez.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated June 9, 2014, 2:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Also add a CMakeProjectVisitorTest for bug 335803</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It doesn't pass, but I think I found the underlying issue. I don't know how to fix it since I am not familiar with the CMake parsing code, but hopefully this test case will help to fix it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectmanagers/cmake/tests/cmakeloadprojecttest.h <span style="color: grey">(9e5cf523e21aa2450b6819b1959906e0654256ad)</span></li>
<li>projectmanagers/cmake/tests/cmakeloadprojecttest.cpp <span style="color: grey">(5a0b1ed52fac800247d6bf2e65afb0d64602020e)</span></li>
<li>projectmanagers/cmake/tests/cmakeprojectvisitortest.h <span style="color: grey">(c491b3bed0e8ab215fcb0a663f8d2e1c93e2f9e5)</span></li>
<li>projectmanagers/cmake/tests/cmakeprojectvisitortest.cpp <span style="color: grey">(37498e8ddc4bb0ea4b8d0ddbc12b67756137d1a7)</span></li>
<li>projectmanagers/cmake/tests/manual/bug335803/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/cmake/tests/manual/bug335803/defines.kdev4 <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118627/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>