<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118542/">https://git.reviewboard.kde.org/r/118542/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 5th, 2014, 2:11 p.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118542/diff/1/?file=278885#file278885line57" style="color: black; font-weight: bold; text-decoration: underline;">language/assistant/renameassistant.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">57</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">SimpleCursor</span> <span class="n">cursor</span><span class="p">(</span><span class="n">changed</span><span class="p">.</span><span class="n">start</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">auto cursor = changed.start();</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Doesn't really qualify for auto, imo.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 5th, 2014, 2:11 p.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118542/diff/1/?file=278891#file278891line138" style="color: black; font-weight: bold; text-decoration: underline;">language/assistant/staticassistantsmanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">138</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">assistant</span><span class="o">-></span><span class="n">supportedLanguage</span><span class="p">()</span> <span class="o">!=</span> <span class="n">language</span><span class="o">-></span><span class="n">languageSupport</span><span class="p">())</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yay in principle.
but: should this be a list or something? could an assistant not support multiple languages or should we keep it as-is and let multiple assistants be registered for every language?
not opening an issue, just want to know your input on that</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, I'd keep it as-is. Having just one language per assistant makes it much easier to manage, imo. Each language can then decide whether it wants to instantiate a RenameAssistant.</pre>
<br />
<p>- Kevin</p>
<br />
<p>On June 9th, 2014, 9:20 a.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated June 9, 2014, 9:20 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move assistant infrastructure to kdevplatform
Noteworthy changes:
* StaticCodeAssistant (from CPP plugin) is now StaticAssistantsManager,
now lives in kdevplatform, so all languages can benefit from it
* RenameAssistant was moved to kdevplatform, as it it useful for all
languages
* BasicRefactoring now has new virtual methods that control the behavior
for renaming actions
LanguageSupport got a new property: refactoring (so languages can expose
their custom BaseRefactoring implementation)
New API:
* New base class for "static" assistants: StaticAssistant
Static assistants exist during the whole session
They are notified when documents change and create solutions based on
that. Current implementations: AdaptDefinitionSignatureAssistant (CPP
language) and RenameAssistant (kdevplatform)
* New manager class: StaticAssistantsManager:
Tracks the StaticAssistant instances, takes care of notifying them
about changes in the editors. Single entry point for registering
StaticAssistants.
Entry-point: LanguageController::staticAssistantsManager</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/ilanguagecontroller.h <span style="color: grey">(57f8651f8e46685c7155db28b9c4277713635a88)</span></li>
<li>language/CMakeLists.txt <span style="color: grey">(0c3af97f733b2c088798f3ee3fb9f6499c968da2)</span></li>
<li>language/assistant/renameaction.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/assistant/renameaction.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/assistant/renameassistant.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/assistant/renameassistant.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/assistant/renamefileaction.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/assistant/renamefileaction.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/assistant/staticassistant.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/assistant/staticassistant.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/assistant/staticassistantsmanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/assistant/staticassistantsmanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/codegen/basicrefactoring.h <span style="color: grey">(8c7f782bdc1f6af9d7d45c7cb7e30aba85f9547e)</span></li>
<li>language/codegen/basicrefactoring.cpp <span style="color: grey">(2b537f329dfacdba1a2890c9cfddd72b2ac60ef8)</span></li>
<li>language/interfaces/ilanguagesupport.h <span style="color: grey">(5c8747b0cf1aee78ed84c8f07989a09e1bd6cb10)</span></li>
<li>language/interfaces/ilanguagesupport.cpp <span style="color: grey">(5797511f19f39ebf1fbcf7662549e698b330bdf6)</span></li>
<li>shell/languagecontroller.h <span style="color: grey">(a4c192603a62dcbb00539004a46cc674df26b998)</span></li>
<li>shell/languagecontroller.cpp <span style="color: grey">(308ec20a6e7f41a271069993010fc46ff696ef56)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118542/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>