<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118596/">https://git.reviewboard.kde.org/r/118596/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Denis Steckelmacher.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-qmljs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When the declaration corresponding to a name is being looked for, and the name is "onXXX", declarations named "XXX" are also returned if they are signals. This allows UseBuilder to register "onClicked" as being an use of the "clicked" signal.
This patch is very general and modifies directly getDeclaration(). This has the advantage that the search logic can be used everywhere (for instance, DeclarationBuilder will soon be able to expose the parameters of a signal to its slot), but getDeclarations() must be very careful not to return an unexpected declaration. For instance, if the user, in a Javascript file, declares an "line" variable, "online" must not be an use of "line". This is done by ensuring that the returned declaration, when "on" has been stripped, is a QML signal.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Two unit tests have been added: one ensures that "onDataChanged" is an use of "dataChanged", and one ensures that "online" is not an use of "line" in Javascript.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>duchain/helper.cpp <span style="color: grey">(27f5dd4)</span></li>
<li>tests/files/plugins.qml <span style="color: grey">(428955c)</span></li>
<li>tests/files/uses.js <span style="color: grey">(b528344)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118596/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>