<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118560/">https://git.reviewboard.kde.org/r/118560/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 9c93e38f9a9667668117c3402ba82669de0a2283 by Denis Steckelmacher to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On June 5th, 2014, 11:11 a.m. UTC, Denis Steckelmacher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Denis Steckelmacher.</div>
<p style="color: grey;"><i>Updated June 5, 2014, 11:11 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-qmljs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Object bindings are objects bound to QML properties, and modifying them. The most used object binding is "Behavior on ... { }". This patch adds support for these object bindings, and recognize them as instances of QML components. In my previous example, a new subclass of Behavior is declared and can have its own properties, id, etc.
The patch is quite simple and handles object bindings the same way as component subclasses were already handled. "Behavior on foo { ... }" is therefore handled exactly as if the user had typed "Behavior { ... }".</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A new unit test ensures that object bindings are properly recognized and act like normal component instantiations.
Behavior on foo {
id: behavior // This is an instance named "behavior" of an anonymous class inheriting from Behavior
}</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>duchain/declarationbuilder.h <span style="color: grey">(908cdcf)</span></li>
<li>duchain/declarationbuilder.cpp <span style="color: grey">(3e885ad)</span></li>
<li>tests/files/test.qml <span style="color: grey">(8e06867)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118560/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>