<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118031/">https://git.reviewboard.kde.org/r/118031/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit fd0f3056154f401d2a6f9f3ea5b2872e609484f2 by Sergey Kalinichev to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On May 7th, 2014, 10:03 a.m. UTC, Sergey Kalinichev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sergey Kalinichev.</div>
<p style="color: grey;"><i>Updated May 7, 2014, 10:03 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Initially I wanted to use ParsingEnvironmentFile approach, but it seems like clang-plugin dosn't use all of it's functionallity (i.e it adds only the current file to the list of dependencies), also it's unclear to me how to handle defines in that approach. So instead I've decided to completly reparse the project.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/iprojectcontroller.h <span style="color: grey">(7ede76fc)</span></li>
<li>language/backgroundparser/parseprojectjob.h <span style="color: grey">(8a6098b)</span></li>
<li>language/backgroundparser/parseprojectjob.cpp <span style="color: grey">(b0adc5e)</span></li>
<li>shell/projectcontroller.h <span style="color: grey">(8c24376)</span></li>
<li>shell/projectcontroller.cpp <span style="color: grey">(5257f49)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118031/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>