<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117407/">https://git.reviewboard.kde.org/r/117407/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 5th, 2014, 8:06 a.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bump. What's the state here? I have the feeling this RR can be abandoned(?)</pre>
</blockquote>
<p>On May 5th, 2014, 9:24 a.m. UTC, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I still think it should be submitted instead of leaving this broken for three more releases.
>From what I understood Simon is still investigating a better option ...?</pre>
</blockquote>
<p>On May 6th, 2014, 10:16 p.m. UTC, <b>Simon Wächter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">From my point of view there are 3 good options:
1.) Provide the project name restriction via regex by the template itself. This needs more work (also in the KAppTemplate project), but is future-proof and allows adding a new category without a change in KDevelop/KDevPlatform/KAppTemplate project.
2.) Set a project name restriction for the template categories, for example C++, Python etc, so we don't have to change the templates. But this needs a change if someone adds a new category - so not the best way.
3.) Simplify the project name as Phil Schaf mentioned it. But with what criterias do we simplify ? Language ? In the end we have to hardcode something - or end in the first version: Just add a general regex.
I think that option 1 is the most solid and future proof solution. But it needs some work and the ok to add a new variable with the regex in every template. If there is an ok from the KAppTemplate and KDevelop site I can start implementing it.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think we can go with 1), we can fallback to a restrictive default as discussed earlier, so that we don't need to rush and patch all templates.</pre>
<br />
<p>- Aleix</p>
<br />
<p>On April 6th, 2014, 7:06 p.m. UTC, Simon Wächter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Sven Brauch.</div>
<div>By Simon Wächter.</div>
<p style="color: grey;"><i>Updated April 6, 2014, 7:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a regex validation for the project name in the project creation dialog. The project name has to start with a/A-z/Z and can contain a/A-z/Z, 0-9 and the _ character.
The idea of this patch is to make an invalid class name in a new project impossible, for example "42fooclass" or "_barclass".</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with several different project strings</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/appwizard/projectselectionpage.cpp <span style="color: grey">(6270869)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117407/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>