<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117938/">https://git.reviewboard.kde.org/r/117938/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 2nd, 2014, 10:26 p.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now, instead of implementing your own clangSetupStandardIncludePaths please just parameterize gccSetupStandardIncludePaths and rename that to something along 'gccLikeSetupStandardIncludePaths'. That output format won't change in the near future, you don't need to fear that. It should parse the Clang output just fine.
We also might want to add support for ICC (Intel Compiler) and/or others, too, at some point. Most of them are interoperable with GCC's interface and offer the same command-line options.</pre>
</blockquote>
<p>On May 2nd, 2014, 10:27 p.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Note: Please make sure this patch actually fixes https://bugs.kde.org/show_bug.cgi?id=314218</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well i test it in my own PC purging all the gcc/g++ installation, only clang installed and the include paths are recognized from clang output... so i think that is fixed. Thanks for the recomendations....</pre>
<br />
<p>- Luis Felipe</p>
<br />
<p>On May 2nd, 2014, 7:38 p.m. UTC, Luis Felipe Dominguez Vega wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Luis Felipe Dominguez Vega.</div>
<div>By Luis Felipe Dominguez Vega.</div>
<p style="color: grey;"><i>Updated May 2, 2014, 7:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When I compile Kdevelop using only in my Debian Testing Clang 3.4, the defaults include paths is not recognized. In the code I will see that the functions are only for GCC and MSVC, with this patch now with Clang are recognized both, the include paths, and standard definitions.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested in my own PC, Debian Testing 64 bits, Clang 3.4, Kernel "Linux 3.13.10lfdominguez #1 SMP PREEMPT Sat Apr 26 17:56:25 UTC 2014 x86_64 GNU/Linux"</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/cpp/CMakeLists.txt <span style="color: grey">(5add7c0)</span></li>
<li>languages/cpp/setuphelpers.cpp <span style="color: grey">(7481256)</span></li>
<li>languages/cpp/setuphelpers_gcc.cpp <span style="color: grey">(83c6052)</span></li>
<li>languages/cpp/setuphelpers_gcc_like.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/cpp/tests/CMakeLists.txt <span style="color: grey">(dcf5087)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117938/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>