<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117835/">https://git.reviewboard.kde.org/r/117835/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 29th, 2014, 12:05 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think this change makes the development of project managers more complex for no reasons.
I don't think project managers should be aware of the includes you want to bypass to the language support.</pre>
</blockquote>
<p>On April 29th, 2014, 4:02 p.m. UTC, <b>Sergey Kalinichev</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">>I don't think project managers should be aware of the includes you want to bypass to the language support.
Huh? I think I lost the thread... What are you talking about?</pre>
</blockquote>
<p>On April 29th, 2014, 11:46 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm saying that I don't think an implementation of a project manager should need to be aware of IDefinesAndIncludesManager. You can have the implementations of IDefinesAndIncludesManager to access the IBuildSystemManager interface or whatever the user defined.
To put it differently, what's the point of implementing a buildsystem manager without includes and defines?</pre>
</blockquote>
<p>On April 30th, 2014, 9:24 a.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Aleix, I'm with Sergey here. At least two of our project managers already don't implement this interface. With the new plugin to define custom include paths/defines, it might be even more eventually.
Then, thinking about the future, we need some kind of interface for other plugins to implement to provide more defines/include paths. Esp. for cross compile toolchains, we must be able to define different compilers to grab the default includes/defines from etc. pp. As such, I think the approach given here goes into the right direction.
And, furthermore, what differences does it make from a IBSM pov? It could just implement the new interface and register itself to the IDAIM, no? I don't think its making things overly complex compared to before?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">My fear is that IBSM might become an ugly beast like ILanguageSupport where semantics are specified in random places and you need somebody who has spent several years in the project just to get another language supported.
I don't really have the energy to get this correctly, so please, at least document the shit out of this. :D</pre>
<br />
<p>- Aleix</p>
<br />
<p>On April 28th, 2014, 11:03 a.m. UTC, Sergey Kalinichev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sergey Kalinichev.</div>
<p style="color: grey;"><i>Updated April 28, 2014, 11:03 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The changes include extending IDM interface and removing i/d notion from IBuildSystemManager interface.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>language/interfaces/idefinesandincludesmanager.h <span style="color: grey">(ab42444)</span></li>
<li>project/interfaces/ibuildsystemmanager.h <span style="color: grey">(241b696)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117835/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>