<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117763/">https://git.reviewboard.kde.org/r/117763/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 25th, 2014, 3:03 p.m. MSK, <b>Olivier Jean de Gaalon</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/117763/diff/2/?file=268184#file268184line122" style="color: black; font-weight: bold; text-decoration: underline;">duchain/parsesession.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">ParseSession::ParseSession(const IndexedString& url, const QByteArray& contents, ClangIndex* index,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">122</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">path</span><span class="p">.</span><span class="n">prepend</span><span class="p">(</span><span class="s">"-include"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If I understand correctly, clang isn't able to use multiple pch files directly, only through chaining (ie file1.pch is created using file2.pch...). I'm not sure what the effect of using multiple -include args will be, IIRC it just ignores them.
In any case, this won't work for kdev-clang as anything coming from the pch won't exist in the resulting ast and thus won't be duchainified.
In summary, I believe the pchInclude path should be the only -include argument, and that it should originally be derived from the IDI you wrote instead of .kdev_pch_include as is currently the case.
I understand this is problematic from a UI perspective at least, but IMO it's not immediately clear to the user that it's even possible to add a pch using the IDI gui currently. I realize that oldcpp can handle multiple pch just fine, but I wonder if the pch shouldn't be a single separate entry.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm a little bit confused of what you're talking about...
Currently I'm trying to handle "automatic include" feature: http://bugs.kde.org/show_bug.cgi?id=315705
>I'm not sure what the effect of using multiple -include args will be, IIRC it just ignores them.
I've just tested it, works for me...
>In any case, this won't work for kdev-clang as anything coming from the pch won't exist in the resulting ast and thus won't be duchainified.
Yep, I've noticed that, but at least kdev-clang doesn't complain anymore about using undeclared identifiers...</pre>
<br />
<p>- Sergey</p>
<br />
<p>On April 25th, 2014, 2:35 p.m. MSK, Sergey Kalinichev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sergey Kalinichev.</div>
<p style="color: grey;"><i>Updated April 25, 2014, 2:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-clang
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make the clang plugin reuse Includes and Defines interface</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>clangparsejob.cpp <span style="color: grey">(d940015)</span></li>
<li>duchain/parsesession.cpp <span style="color: grey">(f0ee15a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117763/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>