<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117656/">https://git.reviewboard.kde.org/r/117656/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 07699e5357392456472decaa15b124eeda29147e by Aleix Pol on behalf of Simon Wächter to branch master.</pre>
 <br />









<p>- Commit Hook</p>


<br />
<p>On April 20th, 2014, 7:34 p.m. UTC, Simon Wächter wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDevelop and Sven Brauch.</div>
<div>By Simon Wächter.</div>


<p style="color: grey;"><i>Updated April 20, 2014, 7:34 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch improves the template provided by KDevelop:

- Variable naming
- Indentation
- Included files
- CMake files (Version, install commands and readability)

If there are other things to improve in the templates, please let it know me.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Templates were succesfully tested with gcc 4.8.2 and clang 3.3 under Debian</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>app_templates/cpp/CMake/cmake_plaincpp/CMakeLists.txt <span style="color: grey">(f649c5f)</span></li>

 <li>app_templates/cpp/CMake/cmake_qt4core/%{APPNAME}.h <span style="color: grey">(e7c7b49)</span></li>

 <li>app_templates/cpp/CMake/cmake_qt4core/CMakeLists.txt <span style="color: grey">(4e91282)</span></li>

 <li>app_templates/cpp/CMake/cmake_qt4core/main.cpp <span style="color: grey">(426830e)</span></li>

 <li>app_templates/cpp/CMake/cmake_qt4core_qtest/%{APPNAME}.h <span style="color: grey">(2d49681)</span></li>

 <li>app_templates/cpp/CMake/cmake_qt4core_qtest/CMakeLists.txt <span style="color: grey">(5e83972)</span></li>

 <li>app_templates/cpp/CMake/cmake_qt4core_qtest/main.cpp <span style="color: grey">(426830e)</span></li>

 <li>app_templates/cpp/CMake/cmake_qt4core_qtest/tests/%{APPNAME}Test.h <span style="color: grey">(02759ec)</span></li>

 <li>app_templates/cpp/CMake/cmake_qt4core_qtest/tests/%{APPNAME}Test.cpp <span style="color: grey">(632a3f8)</span></li>

 <li>app_templates/cpp/CMake/cmake_qt4core_qtest/tests/CMakeLists.txt <span style="color: grey">(a07e256)</span></li>

 <li>app_templates/cpp/CMake/cmake_qt4gui/%{APPNAME}.h <span style="color: grey">(3c50df5)</span></li>

 <li>app_templates/cpp/CMake/cmake_qt4gui/%{APPNAME}.cpp <span style="color: grey">(a1ded84)</span></li>

 <li>app_templates/cpp/CMake/cmake_qt4gui/CMakeLists.txt <span style="color: grey">(c38bdde)</span></li>

 <li>app_templates/cpp/CMake/cmake_qt4gui/main.cpp <span style="color: grey">(67c6ca7)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117656/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>