<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117612/">https://git.reviewboard.kde.org/r/117612/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Denis Steckelmacher.</div>
<p style="color: grey;"><i>Updated April 17, 2014, 7:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-qmljs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sven Brauch has just added a DynamicLanguageExpressionVisitor class in KDevPlatform. This class contains several useful methods for dynamic language expression visitors, such as everything needed to keep track of the current type and current declaration, and also a method that can be used to build a mixed integral type (very nice addition!)
This patch makes ExpressionVisitor inherit from DynamicLanguageExpressionVisitor. The patch is fairly simple as it removes one setType() method and changes every use of setType to encounter(). I also had to change QmlJS::findDeclaration, as it took a DUContextPointer parameter. The problem was that the constructor of DUContextPointer requires a DUContext*, while DynamicLanguageExpressionVisitor only provides a const DUContext*.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All the existing unit tests pass with the simplified expression visitor.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>duchain/expressionvisitor.h <span style="color: grey">(bd82ff2)</span></li>
<li>duchain/expressionvisitor.cpp <span style="color: grey">(a7e0ba6)</span></li>
<li>duchain/helper.h <span style="color: grey">(23a6d0e)</span></li>
<li>duchain/helper.cpp <span style="color: grey">(935ccd8)</span></li>
<li>duchain/usebuilder.cpp <span style="color: grey">(154a4d3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117612/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>