<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116655/">https://git.reviewboard.kde.org/r/116655/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By David Stevens.</div>
<p style="color: grey;"><i>Updated March 16, 2014, 7:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-clang
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ported some code completion functionallity from the existing c++ plugin to kdev-clang. Virtual override completion works for regular functions (not templated functions or signals/slots). Global identifier completion seems to work, although it wasn't the main focus of the work, so some part might have slipped through.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Basic manual testing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>codecompletion/CMakeLists.txt <span style="color: grey">(ec8f690)</span></li>
<li>codecompletion/context.h <span style="color: grey">(aa6fcfb)</span></li>
<li>codecompletion/context.cpp <span style="color: grey">(f6e85d6)</span></li>
<li>codecompletion/helpers.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>codecompletion/helpers.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>codecompletion/implementationhelperitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>codecompletion/implementationhelperitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>codecompletion/item.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>codecompletion/item.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>codecompletion/model.cpp <span style="color: grey">(92cec37)</span></li>
<li>duchain/CMakeLists.txt <span style="color: grey">(d21011a)</span></li>
<li>duchain/adlhelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/adlhelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/cppduchain.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/cppduchain.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/cpptypes.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/cpptypes.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/cursorkindtraits.h <span style="color: grey">(f079380)</span></li>
<li>duchain/overloadresolution.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/overloadresolution.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/overloadresolutionhelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/overloadresolutionhelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/parsesession.h <span style="color: grey">(0abf38f)</span></li>
<li>duchain/templatedeclaration.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/templatedeclaration.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/templateparameterdeclaration.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/templateparameterdeclaration.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/templateresolver.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/templateresolver.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/tuduchain.h <span style="color: grey">(d1a863a)</span></li>
<li>duchain/typeconversion.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/typeconversion.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/typeutils.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/typeutils.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/viablefunctions.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/viablefunctions.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116655/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>