<div dir="ltr">Thank you jeremy!<div><br></div><div>Aleix</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Mar 6, 2014 at 6:30 AM, Jeremy Whiting <span dir="ltr"><<a href="mailto:jpwhiting@kde.org" target="_blank">jpwhiting@kde.org</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">If needed/wanted I can push to frameworks or another branch for merging into frameworks. Up to you.</div>

<div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Mar 5, 2014 at 10:29 PM, Jeremy Whiting <span dir="ltr"><<a href="mailto:jpwhiting@kde.org" target="_blank">jpwhiting@kde.org</a>></span> wrote:<br>


<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">



 <div>
  <div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div>
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 solid">
    <tbody><tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115017/" target="_blank">https://git.reviewboard.kde.org/r/115017/</a>
     </td>
    </tr>
   </tbody></table>
   <br>




</div><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image:url('');background-repeat:repeat-x;border:1px black solid">

 <tbody><tr>
  <td><div>

<div>Review request for KDevelop.</div>
<div>By Jeremy Whiting.</div>


</div><p style="color:grey"><i>Updated March 5, 2014, 10:29 p.m.</i></p>



<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
 <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Rebased on frameworks branch.</pre>
  </td>
 </tr>
</tbody></table><div>







<div style="margin-top:1.5em">
 <b style="color:#575012;font-size:10pt">Repository: </b>
kdevplatform
</div>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
 <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">This completes the unification of libdiff2 by using the libdiff2 from KDE SC 4.12 in kdevplatform.</pre>



  </td>
 </tr>
</tbody></table>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
 <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">It builds.</pre>
  </td>
 </tr>
</tbody></table>


</div><h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs (updated)</h1>
<ul style="margin-left:3em;padding-left:0">

 <li>plugins/patchreview/CMakeLists.txt <span style="color:grey">(9a117a7e71e2dc9ef7fab7407a4b033ab24bf18c)</span></li><div>

 <li>plugins/patchreview/libdiff2/CMakeLists.txt <span style="color:grey">(88c05163602afabc81c663eb0fd0b3db882b2a3b)</span></li>

 <li>plugins/patchreview/libdiff2/README <span style="color:grey">(e75c33e45e937c223b36cdfe22caf8604a7aff39)</span></li>

 <li>plugins/patchreview/libdiff2/cvsdiffparser.h <span style="color:grey">(a642fbd383d6506ec2b159816f773e065eaaab57)</span></li>

 <li>plugins/patchreview/libdiff2/cvsdiffparser.cpp <span style="color:grey">(5b9c25d8a5f33abf16aafacd55b5b8107dadc8f2)</span></li>

 <li>plugins/patchreview/libdiff2/diff2export.h <span style="color:grey">(9d5ebf888601fe5a8ecb788d59c22b48843a13d1)</span></li>

 </div><li>plugins/patchreview/libdiff2/difference.h <span style="color:grey">(b3885d8f613b172bb1690d3e52475d84d11270db)</span></li><div>

 <li>plugins/patchreview/libdiff2/difference.cpp <span style="color:grey">(db455e210ebc8408db98947c7989c14fa4ae1de1)</span></li>

 <li>plugins/patchreview/libdiff2/differencestringpair.h <span style="color:grey">(58fbf462e413dc53cf502ee792826528b0aadc8a)</span></li>

 <li>plugins/patchreview/libdiff2/diffexport.h <span style="color:grey">(f4448d04169e14e06c2e9811b8b6c99d1d262fe7)</span></li>

 <li>plugins/patchreview/libdiff2/diffhunk.h <span style="color:grey">(53dad24a8eb791f24ce92c6c5a9fef8cf4f7e50d)</span></li>

 </div><li>plugins/patchreview/libdiff2/diffhunk.cpp <span style="color:grey">(be2836bb13a5299534e0bcdddda482c379790f4b)</span></li><div>

 <li>plugins/patchreview/libdiff2/diffmodel.h <span style="color:grey">(201768ec41362ff56a1e9da18dec88ee62aaeb93)</span></li>

 <li>plugins/patchreview/libdiff2/diffmodel.cpp <span style="color:grey">(a42e82dc5248ba4fe1f52cebde6ad8deb576b010)</span></li>

 <li>plugins/patchreview/libdiff2/diffmodellist.h <span style="color:grey">(6633456c860480bcfbe5849344ae82c17aa6434c)</span></li>

 <li>plugins/patchreview/libdiff2/diffmodellist.cpp <span style="color:grey">(d76226f03ddcde34b35295027efa9063b38b777b)</span></li>

 <li>plugins/patchreview/libdiff2/diffparser.h <span style="color:grey">(ae7dc84b16d6293fdf9729277d66f16a612de890)</span></li>

 <li>plugins/patchreview/libdiff2/diffparser.cpp <span style="color:grey">(1bd8be613dc62d022b24e0636a505a5dc8d8b466)</span></li>

 <li>plugins/patchreview/libdiff2/kompare.h <span style="color:grey">(6f55c43deb61336221d2bbaa43ae18d712732143)</span></li>

 </div><li>plugins/patchreview/libdiff2/komparemodellist.h <span style="color:grey">(e62b2070b946390d0869a28da3b002f103eb2a1b)</span></li>

 <li>plugins/patchreview/libdiff2/komparemodellist.cpp <span style="color:grey">(e6d283d0be83dfa57b161567d2c033dd41c27db2)</span></li><div>

 <li>plugins/patchreview/libdiff2/kompareprocess.h <span style="color:grey">(907d0f7667a16a97f34fd25650154217b2de93d8)</span></li>

 <li>plugins/patchreview/libdiff2/kompareprocess.cpp <span style="color:grey">(8f50925845a883a33691c95f5e125c12b94c1b7a)</span></li>

 <li>plugins/patchreview/libdiff2/levenshteintable.h <span style="color:grey">(135ce28138010bbf49660ddad3753c80b277a701)</span></li>

 <li>plugins/patchreview/libdiff2/marker.h <span style="color:grey">(cd4ac62ea943b86243f2032cf8f3819459108170)</span></li>

 <li>plugins/patchreview/libdiff2/parser.h <span style="color:grey">(04630f9d5a0be6686cf340bc833d3654d8eb1cfb)</span></li>

 <li>plugins/patchreview/libdiff2/parser.cpp <span style="color:grey">(6e4327b150712bb13d2d88118a9d4ff7aace897f)</span></li>

 <li>plugins/patchreview/libdiff2/parserbase.h <span style="color:grey">(65097744453afa73b02952cea26e8d404e3a1af9)</span></li>

 <li>plugins/patchreview/libdiff2/parserbase.cpp <span style="color:grey">(9b04b85738e1e5ae7831c635cce5fe03435a5dc1)</span></li>

 <li>plugins/patchreview/libdiff2/perforceparser.h <span style="color:grey">(ac78aa61fb391e18b942d5d8ed815caad0115535)</span></li>

 <li>plugins/patchreview/libdiff2/perforceparser.cpp <span style="color:grey">(60060332e96577557e73b98c3a1bb496a0b6ec29)</span></li>

 <li>plugins/patchreview/libdiff2/stringlistpair.h <span style="color:grey">(bdbe2b2cb4198111d5dfb946fc2c21d4217c04ca)</span></li>

 <li>plugins/patchreview/libdiff2/stringlistpair.cpp <span style="color:grey">(3ef34d2476829dc871577c9b5702a2c280d96670)</span></li>

 </div><li>plugins/patchreview/libdiff2/tests/CMakeLists.txt <span style="color:grey">(30e6da412507555e32ed675cf597b402fbfd6e54)</span></li><div>

 <li>plugins/patchreview/libdiff2/tests/interactivedifftest.h <span style="color:grey">(800a8a7f07f5d46f17744c5a9a565bfa1d8344fc)</span></li>

 <li>plugins/patchreview/libdiff2/tests/interactivedifftest.cpp <span style="color:grey">(bb0661c1691ff3c58511b82750804f435a5bcc7a)</span></li>

 <li>plugins/patchreview/libdiff2/tests/levenshteintest.h <span style="color:grey">(b648fb702a276752ab5100fb1f9cfb5a6e33fc8b)</span></li>

 <li>plugins/patchreview/libdiff2/tests/levenshteintest.cpp <span style="color:grey">(f58b9d36d1975fb49e99ea01ae80858d5d4038b2)</span></li>

 </div><li>plugins/patchreview/patchhighlighter.cpp <span style="color:grey">(189a8a16adb60558831f0eece500a2c60f1d3217)</span></li>

 <li>plugins/patchreview/patchreview.h <span style="color:grey">(fe3958a064500b81d7a707d7755761b32b9ba079)</span></li>

 <li>plugins/patchreview/patchreview.cpp <span style="color:grey">(664fc94a18af900295cc102324aa34906ae0c858)</span></li>

 <li>plugins/patchreview/patchreviewtoolview.cpp <span style="color:grey">(15960e9ec6d6a29595fc035eb4f59708cd17b006)</span></li>

 <li>plugins/patchreview/settings/diffsettings.h <span style="color:grey">(28fe89af5065538841c2999067de0a70010f8001)</span></li>

 <li>plugins/patchreview/settings/diffsettings.cpp <span style="color:grey">(081798d34aa6a4d951f1dfd77ad027b39aa8ba4f)</span></li>

 <li>plugins/patchreview/settings/settingsbase.h <span style="color:grey">(81c39d4384794c75cdbfa5dc99f43898e3ed7f4c)</span></li>

 <li>plugins/patchreview/settings/settingsbase.cpp <span style="color:grey">(558b379d3e6861de97757a4dd3439bc7d53f1d09)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115017/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>







  </td>
 </tr>
</tbody></table>




  </div>
 </div>


</blockquote></div><br></div>
</div></div></blockquote></div><br></div>