<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115017/">https://git.reviewboard.kde.org/r/115017/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 15th, 2014, 7:55 a.m. UTC, <b>Andreas Pakulat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">IMO its still too early to do this, at least as a complete replacement. I'd keep the existing code as a fallback so people that have no access to KDE SC 4.12 are not blocked from contributing to KDevelop. KDevelop has always been relatively conservative on its KDE(libs) requirements so even people on slightly older Linux distro releases can use it.</pre>
</blockquote>
<p>On January 15th, 2014, 1 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sure, or maybe it's something we can start adopting on the KF5 branch. Either way, something to be discussed in the sprint.</pre>
</blockquote>
<p>On January 16th, 2014, 2:40 p.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yep I think this should go into the frameworks branch. Keeping libdiff for the KDE 4 version sounds fine to me.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@Jeremy, could rebase this on top of the frameworks branch? Then we can merge this.</pre>
<br />
<p>- Kevin</p>
<br />
<p>On January 14th, 2014, 11:48 p.m. UTC, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Jan. 14, 2014, 11:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This completes the unification of libdiff2 by using the libdiff2 from KDE SC 4.12 in kdevplatform.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It builds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/patchreview/CMakeLists.txt <span style="color: grey">(ba150dcf8f672d6dc4a788acc720b639dfeb78d2)</span></li>
<li>plugins/patchreview/libdiff2/CMakeLists.txt <span style="color: grey">(88c05163602afabc81c663eb0fd0b3db882b2a3b)</span></li>
<li>plugins/patchreview/libdiff2/README <span style="color: grey">(e75c33e45e937c223b36cdfe22caf8604a7aff39)</span></li>
<li>plugins/patchreview/libdiff2/cvsdiffparser.h <span style="color: grey">(a642fbd383d6506ec2b159816f773e065eaaab57)</span></li>
<li>plugins/patchreview/libdiff2/cvsdiffparser.cpp <span style="color: grey">(5b9c25d8a5f33abf16aafacd55b5b8107dadc8f2)</span></li>
<li>plugins/patchreview/libdiff2/diff2export.h <span style="color: grey">(9d5ebf888601fe5a8ecb788d59c22b48843a13d1)</span></li>
<li>plugins/patchreview/libdiff2/difference.h <span style="color: grey">(af1f19c6e2535ecd1554675e5771052e85f66d41)</span></li>
<li>plugins/patchreview/libdiff2/difference.cpp <span style="color: grey">(db455e210ebc8408db98947c7989c14fa4ae1de1)</span></li>
<li>plugins/patchreview/libdiff2/differencestringpair.h <span style="color: grey">(58fbf462e413dc53cf502ee792826528b0aadc8a)</span></li>
<li>plugins/patchreview/libdiff2/diffexport.h <span style="color: grey">(f4448d04169e14e06c2e9811b8b6c99d1d262fe7)</span></li>
<li>plugins/patchreview/libdiff2/diffhunk.h <span style="color: grey">(53dad24a8eb791f24ce92c6c5a9fef8cf4f7e50d)</span></li>
<li>plugins/patchreview/libdiff2/diffhunk.cpp <span style="color: grey">(b76f3d3f603ce2eb82224fbdac82378b3e03cb26)</span></li>
<li>plugins/patchreview/libdiff2/diffmodel.h <span style="color: grey">(201768ec41362ff56a1e9da18dec88ee62aaeb93)</span></li>
<li>plugins/patchreview/libdiff2/diffmodel.cpp <span style="color: grey">(a42e82dc5248ba4fe1f52cebde6ad8deb576b010)</span></li>
<li>plugins/patchreview/libdiff2/diffmodellist.h <span style="color: grey">(6633456c860480bcfbe5849344ae82c17aa6434c)</span></li>
<li>plugins/patchreview/libdiff2/diffmodellist.cpp <span style="color: grey">(d76226f03ddcde34b35295027efa9063b38b777b)</span></li>
<li>plugins/patchreview/libdiff2/diffparser.h <span style="color: grey">(ae7dc84b16d6293fdf9729277d66f16a612de890)</span></li>
<li>plugins/patchreview/libdiff2/diffparser.cpp <span style="color: grey">(1bd8be613dc62d022b24e0636a505a5dc8d8b466)</span></li>
<li>plugins/patchreview/libdiff2/kompare.h <span style="color: grey">(6f55c43deb61336221d2bbaa43ae18d712732143)</span></li>
<li>plugins/patchreview/libdiff2/komparemodellist.h <span style="color: grey">(090791618cdb140ba3b57647accfd208a2fabfca)</span></li>
<li>plugins/patchreview/libdiff2/komparemodellist.cpp <span style="color: grey">(6512235d5c9932852b7b904cd9eca92f4b872bb2)</span></li>
<li>plugins/patchreview/libdiff2/kompareprocess.h <span style="color: grey">(907d0f7667a16a97f34fd25650154217b2de93d8)</span></li>
<li>plugins/patchreview/libdiff2/kompareprocess.cpp <span style="color: grey">(8f50925845a883a33691c95f5e125c12b94c1b7a)</span></li>
<li>plugins/patchreview/libdiff2/levenshteintable.h <span style="color: grey">(135ce28138010bbf49660ddad3753c80b277a701)</span></li>
<li>plugins/patchreview/libdiff2/marker.h <span style="color: grey">(cd4ac62ea943b86243f2032cf8f3819459108170)</span></li>
<li>plugins/patchreview/libdiff2/parser.h <span style="color: grey">(04630f9d5a0be6686cf340bc833d3654d8eb1cfb)</span></li>
<li>plugins/patchreview/libdiff2/parser.cpp <span style="color: grey">(6e4327b150712bb13d2d88118a9d4ff7aace897f)</span></li>
<li>plugins/patchreview/libdiff2/parserbase.h <span style="color: grey">(65097744453afa73b02952cea26e8d404e3a1af9)</span></li>
<li>plugins/patchreview/libdiff2/parserbase.cpp <span style="color: grey">(9b04b85738e1e5ae7831c635cce5fe03435a5dc1)</span></li>
<li>plugins/patchreview/libdiff2/perforceparser.h <span style="color: grey">(ac78aa61fb391e18b942d5d8ed815caad0115535)</span></li>
<li>plugins/patchreview/libdiff2/perforceparser.cpp <span style="color: grey">(60060332e96577557e73b98c3a1bb496a0b6ec29)</span></li>
<li>plugins/patchreview/libdiff2/stringlistpair.h <span style="color: grey">(bdbe2b2cb4198111d5dfb946fc2c21d4217c04ca)</span></li>
<li>plugins/patchreview/libdiff2/stringlistpair.cpp <span style="color: grey">(3ef34d2476829dc871577c9b5702a2c280d96670)</span></li>
<li>plugins/patchreview/libdiff2/tests/CMakeLists.txt <span style="color: grey">(61ea7ef83dd244031cad41d3f1ed0a6119f373f4)</span></li>
<li>plugins/patchreview/libdiff2/tests/interactivedifftest.h <span style="color: grey">(800a8a7f07f5d46f17744c5a9a565bfa1d8344fc)</span></li>
<li>plugins/patchreview/libdiff2/tests/interactivedifftest.cpp <span style="color: grey">(bb0661c1691ff3c58511b82750804f435a5bcc7a)</span></li>
<li>plugins/patchreview/libdiff2/tests/levenshteintest.h <span style="color: grey">(b648fb702a276752ab5100fb1f9cfb5a6e33fc8b)</span></li>
<li>plugins/patchreview/libdiff2/tests/levenshteintest.cpp <span style="color: grey">(f58b9d36d1975fb49e99ea01ae80858d5d4038b2)</span></li>
<li>plugins/patchreview/patchhighlighter.cpp <span style="color: grey">(2fe6690e988d4de9f313afaf28fcc1791e1ac515)</span></li>
<li>plugins/patchreview/patchreview.h <span style="color: grey">(b5b15fa1b241208c8f000e90ab91de9af5d665fb)</span></li>
<li>plugins/patchreview/patchreview.cpp <span style="color: grey">(596ada5b54a4e3ec5a7f46f3b398ce9682c842f5)</span></li>
<li>plugins/patchreview/patchreviewtoolview.cpp <span style="color: grey">(97b2d15cab4ddbd655bb03d92814a1d8893029ab)</span></li>
<li>plugins/patchreview/settings/diffsettings.h <span style="color: grey">(c88fa14561652015c6f4fdde1fa403ac8797b046)</span></li>
<li>plugins/patchreview/settings/diffsettings.cpp <span style="color: grey">(081798d34aa6a4d951f1dfd77ad027b39aa8ba4f)</span></li>
<li>plugins/patchreview/settings/settingsbase.h <span style="color: grey">(81c39d4384794c75cdbfa5dc99f43898e3ed7f4c)</span></li>
<li>plugins/patchreview/settings/settingsbase.cpp <span style="color: grey">(a68c3bb2de55063fa4984c573fb80e975aa066e4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115017/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>