<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115992/">https://git.reviewboard.kde.org/r/115992/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Milian Wolff.</div>
<div>By Olivier Jean de Gaalon.</div>
<p style="color: grey;"><i>Updated March 3, 2014, 6:36 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-clang
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a little dirty, but I probably won't be able to work on it any more this week, so at least I can throw it up for feedback. Give special attention to parselock, because I didn't take the time to see how it's supposed to be used.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It works, including with epic-size projects. It still doesn't resume properly for some reason (clang will complain about invalid PCH, create an invalid tu, and the pch contexts will be nuked). I haven't had time to look into that, just have to remove the pch and rebuild for now.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>duchain/clanghelpers.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/CMakeLists.txt <span style="color: grey">(7ab2e8a)</span></li>
<li>clangparsejob.cpp <span style="color: grey">(86588ce)</span></li>
<li>clangparsejob.h <span style="color: grey">(b12e9df)</span></li>
<li>duchain/clanghelpers.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/clangpch.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/clangpch.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/clangtypes.h <span style="color: grey">(b4baba7)</span></li>
<li>duchain/clangtypes.cpp <span style="color: grey">(f8eb8b8)</span></li>
<li>duchain/includedfilecontexts.h <span style="color: grey">(4bdd6ca)</span></li>
<li>duchain/includedfilecontexts.cpp <span style="color: grey">(90d800c)</span></li>
<li>duchain/parsesession.h <span style="color: grey">(e557884)</span></li>
<li>duchain/parsesession.cpp <span style="color: grey">(265e099)</span></li>
<li>duchain/tuduchain.h <span style="color: grey">(e0e8d44)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115992/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>