<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115991/">https://git.reviewboard.kde.org/r/115991/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 24th, 2014, 9:02 a.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In principle this is fine, but what this will break (or will it?), is the case where you add custom Doxygen to a variable/member. In such a case, you'll now only see the builtin Qt documentation, no?
i.e.:
class foo {
/**
* Fancy comment should be shown in documentation.
*/
QPoint bar;
};
Would be cool if we could combine both documentations somehow... But probably thats not feasible. So I'd vote to make it only fall back to builtin documentation if no other documentation exists. </pre>
</blockquote>
<p>On February 24th, 2014, 9:44 a.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That still works, comments are still prepended to the navigation widget (handled by abstractdeclarationnavigationcontext.cpp separately).
However, I've just noticed that the navigation widget now shows "Show documentation for 'foo::bar'" instead of 'QPoint', which is misleading. I'll give this patch another thought.
But being able to quickly fire up the documentation for anything under your cursor is quite helpful, IMO, other IDEs do that, too.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Btw, the 'fix' is easy: Apply this patch to DocumentationController::doShowDocumentation() instead (so this only affects the shortcut) and we're done.
Makes sense to you?</pre>
<br />
<p>- Kevin</p>
<br />
<p>On February 24th, 2014, 8:53 a.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated Feb. 24, 2014, 8:53 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Be able to get documentation for type of instances
Example:
"QPoint point;"
^-- cursor here
=> Now the "Show Documentation" shortcut retrieves the help of "QPoint",
didn't do anything before this patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/documentationcontroller.cpp <span style="color: grey">(2ea4347ed0492d8ffa2fc67c7bf2e68ad61c703c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115991/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>