<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115095/">https://git.reviewboard.kde.org/r/115095/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, a test would be extremely useful for this. Could you add one? It should be rather straight forward, just copy what we do for append currently. See cmakeasttest.cpp e.g.</pre>
<br />
<p>- Milian Wolff</p>
<br />
<p>On January 17th, 2014, 11:55 p.m. UTC, Ben Wagner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Ben Wagner.</div>
<p style="color: grey;"><i>Updated Jan. 17, 2014, 11:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">With CMake 2.8.6 there was added an APPEND_STRING option to set_property. In CMake, APPEND appends a ';' to the existing value (when it exists and is non-empty). APPEND_STRING does not append this ';'. This was a simple change in CMake, but adds another odd corner case to KDevelop.
The parser in CMake will simply hold all appends as a string, and parse that string to a list as needed. In KDevelop the value is always held as a list, so the odd case (which is possible in CMake) where an individual list value is created over multiple commands is not easily emulated in the KDevelop parser.
Seeing as full support is a rather large change, this change simply makes APPEND_STRING an alias for APPEND in KDevelop which handles almost all cases.
This will probably need a test, and this may or may not be the best way to do this, but it seems better than failing to parse the set_properties command at all.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built. Seems to work ok. Probably needs a real test.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectmanagers/cmake/parser/cmakeast.cpp <span style="color: grey">(aac1070)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115095/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>