<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115600/">https://git.reviewboard.kde.org/r/115600/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 5845a0ddd4bb6749a9d01a95b5417d43225e817f by Milian Wolff on behalf of Todd Nowacki to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On February 9th, 2014, 6:57 p.m. UTC, Todd Nowacki wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Alexander Dymo.</div>
<div>By Todd Nowacki.</div>
<p style="color: grey;"><i>Updated Feb. 9, 2014, 6:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=330206">330206</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is in response to https://bugs.kde.org/show_bug.cgi?id=330206
I added buttons to all output widgets instead of the one for the build tool view; we can easily restrict this to a certain type of view if we want to.
The only problem with the buttons is that they are enabled even if there are no outputmarks to jump to. At the time of creating this diff, I did not see an easy way to find the number of outputmark.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The buttons work for the build window.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/standardoutputview/outputwidget.h <span style="color: grey">(98cd94988b9a278b6509702c18956e580226ffc9)</span></li>
<li>plugins/standardoutputview/outputwidget.cpp <span style="color: grey">(7f248c4924ba4c2129f1f1fa7b28d7fd6ab6a7ed)</span></li>
<li>plugins/standardoutputview/standardoutputview.cpp <span style="color: grey">(60379a9a909a27b1c611344ad47476b84a91141a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115600/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>