<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115770/">https://git.reviewboard.kde.org/r/115770/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 16th, 2014, 11:28 a.m. CET, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115770/diff/1-2/?file=244304#file244304line74" style="color: black; font-weight: bold; text-decoration: underline;">duchain/expressionvisitor.cpp</a>
<span style="font-weight: normal;">
(Diff revisions 1 - 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ExpressionVisitor::visitBuiltInType(BuiltInTypeAst* node) {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">74</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">KDevPG</span><span class="o">::</span><span class="n">ListNode</span><span class="o"><</span><span class="n">ClassOrInterfaceTypeNamePartAst</span><span class="o">*></span> <span class="o">*</span><span class="n">__it</span> <span class="o">=</span> <span class="n">node</span><span class="o">-></span><span class="n">partSequence</span><span class="o">-></span><span class="n">front</span><span class="p">(),</span> <span class="o">*</span><span class="n">__end</span> <span class="o">=</span> <span class="n">__it</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">74</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">auto</span> <span class="n">it</span> <span class="o">=</span> <span class="n">node</span><span class="o">-></span><span class="n">partSequence</span><span class="o">-></span><span class="n">front</span><span class="p">(),</span> <span class="n">end</span> <span class="o">=</span> <span class="n">it</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In fact -- sorry for not looking at this closely the first time -- why not just
for ( const auto& item: node->partSequence ) {
QString ident = ...(item.element->...);
id.push(...)
}
?
But doesn't matter much of course ;)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">foreach doesn't work with this kind of list. There's no begin() and end() in ListNode.</pre>
<br />
<p>- Matija</p>
<br />
<p>On February 16th, 2014, 3:37 a.m. CET, Matija Skala wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Matija Skala.</div>
<p style="color: grey;"><i>Updated Feb. 16, 2014, 3:37 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-java
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Expression visitor should not inherit from the context builder
and should not visit the whole compilation unit.
This commit fixes the problem with variable colors.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>duchain/abstractexpressionvisitor.h <span style="color: grey">(a590096)</span></li>
<li>duchain/expressionvisitor.h <span style="color: grey">(652a2cd)</span></li>
<li>duchain/expressionvisitor.cpp <span style="color: grey">(95b660f)</span></li>
<li>duchain/usebuilder.h <span style="color: grey">(48e591d)</span></li>
<li>duchain/usebuilder.cpp <span style="color: grey">(527e813)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115770/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>