<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115637/">https://git.reviewboard.kde.org/r/115637/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 11th, 2014, 10:25 a.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A few minor nitpicks, then go for it!
Just a hint: This approach is a good to get things going in a first approximation. But it will probably fail as soon as you have nested contexts, no? I.e. when you start visiting, you "inject" the top context but where are the sub contexts set as the current context from which to search for declarations? Anyhow - this is something you should investigate later then and we can come up with a way to fix it then.
Thanks for working on this!</pre>
</blockquote>
<p>On February 11th, 2014, 11:23 a.m. UTC, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We discussed that yesterday on IRC. It's a bit convoluted. The weird thing is that the ExpressionVisitor inherits from the ContextBuilder, thus nested contexts *should* work fine. The injectContext is a hack to make it work for the top context too, which is *usually* opened by AbstractContextBuiler::supportBuild(), which cannot be used in this case because otherwise the cleanup logic will run and delete stuff you don't want deleted.
All this is certainly not optimal but as you said -- let's first try to get it working a bit.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To clarify this -- the weird thing in my eyes is that the ExpressionVisitor doesn't really visit only expressions, but traverses the whole AST.</pre>
<br />
<p>- Sven</p>
<br />
<p>On February 11th, 2014, 3:33 a.m. UTC, Matija Skala wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Matija Skala.</div>
<p style="color: grey;"><i>Updated Feb. 11, 2014, 3:33 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-java
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">so that uses of variables are detected. The startVisiting() function might seem a bit hacky, but it works and produces no new issues. I will improve it in one of the future commits.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>duchain/usebuilder.h <span style="color: grey">(2c13dff)</span></li>
<li>duchain/usebuilder.cpp <span style="color: grey">(513c03c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115637/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>