<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/113815/">https://git.reviewboard.kde.org/r/113815/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 14th, 2013, 4:03 p.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Okay, there are some issues with this patch. In theory you shouldn't touch the unresolvedincludeassistant.* files at all. You want to modify the behavior of the custom include paths widget, hence you need also need to touch just that.
Proposed change: Make the include path resolver a proper widget subclass, e.g. by providing also a .cpp and .h to the .ui. That's the pattern used when widgets have more complex logic inside. When you have the .cpp and .h file, move the logic you added to unresolvedincludeassistant.* to those newly created files. Signal/slot handling will get much easier when you do it this way.
The .cpp/.h/.ui pattern is a commonly used in Qt, you can see several examples in the kdevelop code base.
Does that make sense to you?</pre>
</blockquote>
<p>On November 15th, 2013, 8:54 a.m. UTC, <b>Meenakshi Khorana</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If i wont touch unresolvedincludeassistant.*, where signal-slot mapping will go?
Can you please share some reference/example for the same.</pre>
</blockquote>
<p>On November 15th, 2013, 1:41 p.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That will go into custom_include_paths.cpp. You can connect to the clicked() signal in the yet-to-created CustomIncludePaths ctor and then just invoke a slot from the CustomIncludePaths class.
http://techbase.kde.org/Development/Tutorials/Using_Qt_Designer#Using_the_UI_in_Your_Code is a good resource for that.</pre>
</blockquote>
<p>On November 15th, 2013, 1:42 p.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@Meenakshi: Feel free to join us in #kdevelop on Freenode (IRC), that way it's much easier to coordinate your work.</pre>
</blockquote>
<p>On November 18th, 2013, 10:13 a.m. UTC, <b>Meenakshi Khorana</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Let me re-phrase my question... Do i have to create new ui file for a push button. As per my understanding, it should go to same ui file (custom_include_paths.ui) so if the button is defined in that ui file and "Setup Custom Include Path" dialog gets created in unresolvedclassassistant.cpp , how would my new class will get reference of same without touching unresolvedclassassistant.*
I am stuck.. Please assist...</pre>
</blockquote>
<p>On November 25th, 2013, 7:15 a.m. UTC, <b>Meenakshi Khorana</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you please share some sample reference from existing kdevplatform/kdevelop code.</pre>
</blockquote>
<p>On November 29th, 2013, 11:06 a.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@Meenakshi: You have to create a .cpp and .h file for that uses custom_include_path.ui. Again, see http://techbase.kde.org/Development/Tutorials/Using_Qt_Designer#Using_the_UI_in_Your_Code for a good tutorial how to do that. The button you created in custom_include_paths.ui is fine as-is, you don't need to modify that. The signal/slot mapping will then go to custom_include_paths.{cpp,h}.
Then, in unresolvedincludeassistant.cpp you'd use the 'CustomIncludePaths' class instead of Ui::CustomIncludePaths. 'CustomIncludePaths' is the class you'll be creating when implementing custom_include_paths.{cpp,h}. That's the only thing you need to change in unresolvedincludeassistant.cpp.
Hope that helps</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@Kevin: I have made the changes. Can you please verify the same. Thanks.</pre>
<br />
<p>- Meenakshi</p>
<br />
<p>On January 17th, 2014, 7:43 a.m. UTC, Meenakshi Khorana wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Meenakshi Khorana.</div>
<p style="color: grey;"><i>Updated Jan. 17, 2014, 7:43 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch for Bug 221792 - integrate folder browser in "Setup Custom Include Paths"
Integrated a folder browser to add custom include paths. User can add custom include paths on a button click and can view the added paths in plain text edit box.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled and Tested successfully on local machine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/cpp/CMakeLists.txt <span style="color: grey">(66030be)</span></li>
<li>languages/cpp/codegen/customincpath.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/cpp/codegen/customincpath.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>languages/cpp/codegen/ui/custom_include_paths.ui <span style="color: grey">(1a7c1ed)</span></li>
<li>languages/cpp/codegen/unresolvedincludeassistant.cpp <span style="color: grey">(93a72d3)</span></li>
<li>languages/cpp/tests/CMakeLists.txt <span style="color: grey">(9ce3c7b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/113815/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/11/12/34ab7f7c-7aca-4c16-ab3f-add513c22f56__folder_browser_1.jpg">Added open file dialog to custom include path</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/11/12/29a48901-93ee-40e7-9455-94acb648025e__folder_browser_2.jpg">Folder browser for selecting include paths</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/11/12/bf9fb89b-8e6e-49f8-b2b5-d865ded209b7__folder_browser_3.jpg">Added include paths will be visible to user in text edit</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>