<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115232/">https://git.reviewboard.kde.org/r/115232/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Your patch crashes kdevelop. :(
Steps to reproduce: code->commit current project. Don't commit anything. Review->back to code. Then again Code->commit current project:
#5 0x00007fdf8b87e1d5 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
#6 0x00007fdf8b881388 in __GI_abort () at abort.c:90
#7 0x00007fdf8c47cc52 in qt_message_output(QtMsgType, char const*) () from /usr/lib/x86_64-linux-gnu/libQtCore.so.4
#8 0x00007fdf8c47cfb9 in ?? () from /usr/lib/x86_64-linux-gnu/libQtCore.so.4
#9 0x00007fdf8c47d7c4 in qFatal(char const*, ...) () from /usr/lib/x86_64-linux-gnu/libQtCore.so.4
#10 0x00007fdf8f53c11e in Sublime::IdealController::removeView (this=0x26b5bb0, view=0x6354120, nondestructive=true) at /home/ks/Projects/kdevel/kdevplatform/sublime/idealcontroller.cpp:327
#11 0x00007fdf8f53609e in Sublime::MainWindowPrivate::clearArea (this=0x26b1e40) at /home/ks/Projects/kdevel/kdevplatform/sublime/mainwindow_p.cpp:399
#12 0x00007fdf8f531152 in clearArea (this=<optimized out>) at /home/ks/Projects/kdevel/kdevplatform/sublime/mainwindow.cpp:166
#13 Sublime::MainWindow::setArea (this=0x26af020, area=0x26fbec0) at /home/ks/Projects/kdevel/kdevplatform/sublime/mainwindow.cpp:119
#14 0x00007fdf8f52c3f6 in showAreaInternal (this=<optimized out>, area=<optimized out>, mainWindow=<optimized out>, this=<optimized out>, area=<optimized out>, mainWindow=<optimized out>) at /home/ks/Projects/kdevel/kdevplatform/sublime/controller.cpp:145
#15 Sublime::Controller::showArea (this=0x26acb40, areaTypeId=..., mainWindow=0x26af020) at /home/ks/Projects/kdevel/kdevplatform/sublime/controller.cpp:166
#16 0x00007fdf90f49115 in KDevelop::UiController::switchToArea (this=0x26acb40, areaName=..., switchMode=<optimized out>) at /home/ks/Projects/kdevel/kdevplatform/shell/uicontroller.cpp:249
#17 0x00007fdedada9068 in PatchReviewPlugin::switchAreaAndMakeWorkingSetUique (this=0x486d430) at /home/ks/Projects/kdevel/kdevplatform/plugins/patchreview/patchreview.cpp:368
#18 0x00007fdedada9428 in PatchReviewPlugin::updateReview (this=0x486d430) at /home/ks/Projects/kdevel/kdevplatform/plugins/patchreview/patchreview.cpp:406
#19 0x00007fdedadab12d in PatchReviewPlugin::qt_static_metacall (_o=0x486d430, _c=<optimized out>, _id=<optimized out>, _a=<optimized out>) at /home/ks/Projects/kdevel/kdevplatform/build/plugins/patchreview/patchreview.moc:76
....
NOTE: This doesn't happen without your patch applied.</pre>
<br />
<p>- Sergey Kalinichev</p>
<br />
<p>On January 27th, 2014, 9:15 p.m. MSK, Mikhail Krutov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Mikhail Krutov.</div>
<p style="color: grey;"><i>Updated Jan. 27, 2014, 9:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When user commits something, he doesn't get back to VcsView after reviewing commit in patchreview. This fixes the issue. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Install kdevgit.so plugin, then run KDevelop, init repo, commit something.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/patchreview/patchreview.cpp <span style="color: grey">(a582b0a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115232/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>