<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115121/">https://git.reviewboard.kde.org/r/115121/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 922eb8c338269902fb231a061bc3ca7a1d29fb70 by Heinz Wiesinger to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On January 19th, 2014, 12:51 p.m. UTC, Heinz Wiesinger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Heinz Wiesinger.</div>
<p style="color: grey;"><i>Updated Jan. 19, 2014, 12:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Change the command to get the current branch name for git.
"git sumbolic-ref" also provides a valid branch name when the
repository is empty. In detached HEAD state it has an empty
output, which is exactly what we did before manually. However,
in that case it also returns with a non-zero exit code which
we need to ignore.
- Add an ignoreError flag to the DVcsJob class.
This allows ignoring non-zero exit codes and treat the Job as though
it completed successfully. This is useful if the output of the Job
already contains sufficient information so that handling a special
error code is no longer necessary.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Local testing with empty repository, detached HEAD and standard branches.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/git/gitplugin.cpp <span style="color: grey">(4b5e54b12a7c54604e8c99de0418c7c4bbe82b3b)</span></li>
<li>vcs/dvcs/dvcsjob.h <span style="color: grey">(2a45ab1b4abb4c23176b74144c477a49cb8cb8b8)</span></li>
<li>vcs/dvcs/dvcsjob.cpp <span style="color: grey">(6b5a645b3ee63d10c890b35bdb85e459f5278ccc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115121/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>