<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115117/">https://git.reviewboard.kde.org/r/115117/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Milian Wolff</p>
<br />
<p>On January 20th, 2014, 2:49 p.m. UTC, Heinz Wiesinger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Heinz Wiesinger.</div>
<p style="color: grey;"><i>Updated Jan. 20, 2014, 2:49 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=255537">255537</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-php
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Handle global variables in namespaces correctly.
PHP does not support namespaced variables. Variable declarations
inside a namespace are just global declarations.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit tests and parsing various test files</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>duchain/tests/uses.h <span style="color: grey">(16b7303df21616726814095337c6cc0a779de951)</span></li>
<li>duchain/tests/uses.cpp <span style="color: grey">(eac94603e7d86c5c9b8efdb804372a729e3e8cd1)</span></li>
<li>duchain/builders/declarationbuilder.cpp <span style="color: grey">(24d68558f3ea8528ca7e66338bb8e8405849aecb)</span></li>
<li>duchain/expressionvisitor.h <span style="color: grey">(97bfb8ea4b8cb56b8011fe8974a682aee22bc16c)</span></li>
<li>duchain/expressionvisitor.cpp <span style="color: grey">(6374a63b7fa41b9a0a14aeb69e571211eab8ac63)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115117/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>