<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114775/">https://git.reviewboard.kde.org/r/114775/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Vlas Puhov.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Right now if we stop in code without debug symbols installed we'll end up in creating a new file (well actually we were, this patch 7bb3e70e51d3c790efeb8ec1020f96bdc70a78ab by Kevin Funk partially fixes it. Still e.g. double clicking on a breakpoint without existing location would create a new file.)
So this patch prevents creating of new files by checking if we're in the "code mode". I think it makes sense, because I see no real reason why it'd be useful to create a new file in the debug or the review mode? There is the edit mode for code editing after all.
Instead we emit new showStepInDisassemble signal, indicating that there is no debug symbols/file available.
Also there is no need in preselecting a frame stack with debug symbols anymore (as DisassembleWidget takes care of it), so I've removed this hack too.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debugger/framestack/framestackmodel.cpp <span style="color: grey">(0f79538)</span></li>
<li>debugger/interfaces/idebugsession.h <span style="color: grey">(33e456d)</span></li>
<li>debugger/interfaces/idebugsession.cpp <span style="color: grey">(e14f808)</span></li>
<li>shell/debugcontroller.cpp <span style="color: grey">(a9f1eec)</span></li>
<li>shell/documentcontroller.cpp <span style="color: grey">(ad0a58f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114775/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>