<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114323/">http://git.reviewboard.kde.org/r/114323/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Jup, looks nice. One small cleanup then feel free to commit!
Thanks</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/114323/diff/3/?file=224593#file224593line246" style="color: black; font-weight: bold; text-decoration: underline;">shell/session.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">SessionInfo Session::parse( const QString& id, bool mkdir )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">208</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ret</span><span class="p">.</span><span class="n">description</span> <span class="o">=</span> <span class="n">generateDescription</span><span class="p">(</span> <span class="n">ret</span><span class="p">,</span> <span class="n">ret</span><span class="p">.</span><span class="n">config</span><span class="o">-></span><span class="n">group</span><span class="p">(</span> <span class="n">QString</span><span class="p">()</span> <span class="p">).</span><span class="n">readEntry</span><span class="p">(</span> <span class="s">"SessionPrettyContents"</span><span class="p">,</span> <span class="n">QString</span><span class="p">()</span> <span class="p">)</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">225</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ret</span><span class="p">.</span><span class="n">config</span><span class="o">-></span><span class="n">group</span><span class="p">(</span><span class="s">""</span><span class="p">).</span><span class="n">deleteEntry</span><span class="p">(</span> <span class="s">"SessionPrettyContents"</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">group(QString()), and maybe put this group into a named variable and reuse it below</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/114323/diff/3/?file=224593#file224593line248" style="color: black; font-weight: bold; text-decoration: underline;">shell/session.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">SessionInfo Session::parse( const QString& id, bool mkdir )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">227</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ret</span><span class="p">.</span><span class="n">name</span> <span class="o">=</span> <span class="n">ret</span><span class="p">.</span><span class="n">config</span><span class="o">-></span><span class="n">group</span><span class="p">(</span><span class="s">""</span><span class="p">).</span><span class="n">readEntry</span><span class="p">(</span> <span class="n">cfgSessionNameEntry</span><span class="p">,</span> <span class="n">QString</span><span class="p">()</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">group( QString() )</pre>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On December 12th, 2013, 3:20 p.m. UTC, Ivan Shapovalov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Ivan Shapovalov.</div>
<p style="color: grey;"><i>Updated Dec. 12, 2013, 3:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fixes session list and window title not reflecting actual session data (name and project list).
Things done:
1) project list is written to the session via a new interface method (ISession::setContainedProjects()) instead of directly writing to the session's config
2) signal Session::nameChanged() is replaced by Session::sessionUpdated(), which is called on both name change and project list change
3) anything that displays session contents now listens only to that signal instead of nameChanged()+projectOpened()+projectClosed()</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works as expected and unit-tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/isession.h <span style="color: grey">(d96695d)</span></li>
<li>shell/mainwindow.cpp <span style="color: grey">(ddb07f5)</span></li>
<li>shell/projectcontroller.cpp <span style="color: grey">(ee89dd7)</span></li>
<li>shell/session.h <span style="color: grey">(0154156)</span></li>
<li>shell/session.cpp <span style="color: grey">(9fdd31f)</span></li>
<li>shell/sessioncontroller.h <span style="color: grey">(1986360)</span></li>
<li>shell/sessioncontroller.cpp <span style="color: grey">(3be453e)</span></li>
<li>shell/tests/sessioncontrollertest.cpp <span style="color: grey">(d7e9093)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114323/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>