<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114197/">http://git.reviewboard.kde.org/r/114197/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 81c5f4cda2c9adcfbeeb75de9cf697d01d17cb92 by Kevin Funk to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On December 4th, 2013, 10:43 p.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated Dec. 4, 2013, 10:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">EnvironmentWidget: Always display placeholder line
Implement a custom proxy model that just adds another line at the end of
the list. This line servers as a placeholder item. When setting data on
that placeholder item, the EnvironmentWidget instance is notified and
takes care of adding the actual value to the EnvironmentGroupModel
instance.
The new PlaceholderItemProxyModel should be useful for similar widgets
as well. For example, the BreakpointModel uses a similar approach,
but includes the placeholder item directly in the source QAIM. => Cleanup up
BreakPointModel and use this proxy to simplify code.
REVIEW: 114197
EnvironmentGroupModel: More API fixes</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bump</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/settings/environmentgroupmodel.h <span style="color: grey">(5654e00121479333fea4a044f482db1622cb8851)</span></li>
<li>shell/settings/environmentgroupmodel.cpp <span style="color: grey">(63c25020e65dcc33d517c36ca1c18176fc61272c)</span></li>
<li>shell/settings/environmentwidget.h <span style="color: grey">(9f89ff070c0ea649bbc8c5d73a16c1b027c102bd)</span></li>
<li>shell/settings/environmentwidget.cpp <span style="color: grey">(68d825ccf98ce9a54023107b4a889c06bd56727a)</span></li>
<li>shell/settings/environmentwidget.ui <span style="color: grey">(f9683307c0a2d61d42b04ba720be2b4f30143277)</span></li>
<li>util/CMakeLists.txt <span style="color: grey">(87384bd70f3fa5e0696883a05a6a5efe18ebfd49)</span></li>
<li>util/placeholderitemproxymodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>util/placeholderitemproxymodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114197/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>