<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114310/">http://git.reviewboard.kde.org/r/114310/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, but please extend the commit message before pushing it.</pre>
<br />
<p>- Milian Wolff</p>
<br />
<p>On December 5th, 2013, 9:18 a.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated Dec. 5, 2013, 9:18 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Parse '$' in macro identifiers
At least GCC and MSVC support this. See diff for further explanation.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/cpp/parser/rpp/chartools.h <span style="color: grey">(eec59e1aeb049c1ec2380be89344c27fca22ce1a)</span></li>
<li>languages/cpp/parser/rpp/chartools.cpp <span style="color: grey">(4c8f746fda18a2303e016941d66e5380843bf12d)</span></li>
<li>languages/cpp/parser/rpp/pp-scanner.cpp <span style="color: grey">(8b36bcb90bf0f44d5aab0191905368117bc9d355)</span></li>
<li>languages/cpp/parser/tests/test_parser.cpp <span style="color: grey">(f4a4dbb1f9d39f3bb460754b127f3b48fcd03471)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114310/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>