<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113599/">http://git.reviewboard.kde.org/r/113599/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113599/diff/1/?file=208957#file208957line557" style="color: black; font-weight: bold; text-decoration: underline;">debuggers/gdb/printers/qt4.py</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">def to_string(self):</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">555</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="nb"><span class="hl">uni</span>chr</span><span class="p">(</span><span class="bp">self</span><span class="o">.</span><span class="n">val</span><span class="p">[</span><span class="s">'ucs'</span><span class="p">])</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">557</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="nb">chr</span><span class="p">(</span><span class="bp">self</span><span class="o">.</span><span class="n">val</span><span class="p">[</span><span class="s">'ucs'</span><span class="p">])</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Didn't notice that hunk, that was done by the Python 2to3 porting tool -- This still needs to be unichr() in Py2.x, will fix locally.</pre>
</div>
<br />
<p>- Kevin Funk</p>
<br />
<p>On November 4th, 2013, 8:22 a.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Niko Sams.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated Nov. 4, 2013, 8:22 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Consists of multiple commits:
Add test for KDE4 printers
---
Pretty-printers: Make compatible with Python 3.x
Also add helper.py, this module contains:
* Compatibility functions for Python 2.x & 3.x.
* Shared LookupFunction class
---
qtprinters test: Pass '-nh' to gdb process
---
qtprinters test: Error out early on exception</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debuggers/gdb/printers/CMakeLists.txt <span style="color: grey">(d30352e0c0ea28bff92a8526a85a504e765d4a3a)</span></li>
<li>debuggers/gdb/printers/helper.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>debuggers/gdb/printers/kde4.py <span style="color: grey">(47294eb201a9da39b41fd19c643fb52bf02b6916)</span></li>
<li>debuggers/gdb/printers/qt4.py <span style="color: grey">(03064c0377b036c98d114f0b16ea783210ed68b0)</span></li>
<li>debuggers/gdb/printers/tests/CMakeLists.txt <span style="color: grey">(aea9637ec16e12c0868bd693c995d10802ab77c3)</span></li>
<li>debuggers/gdb/printers/tests/ktexteditortypes.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>debuggers/gdb/printers/tests/qtprinters.h <span style="color: grey">(1ec38684b8281c23bab941c2345db72d53f319aa)</span></li>
<li>debuggers/gdb/printers/tests/qtprinters.cpp <span style="color: grey">(e05964ababc3a84848dc0beae4f4021d9da5cf59)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113599/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>