<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112787/">http://git.reviewboard.kde.org/r/112787/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 7abaa315dc7726e5e5b5a8642c2721c04c55d5ef by Sven Brauch to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On October 19th, 2013, 10:39 p.m. UTC, Sven Brauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Kate and KDevelop.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated Oct. 19, 2013, 10:39 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">(I'll put this up here for discussion, I think a bit more work is required before submission.)
This patch implements less restrictive rules for completion list filtering. Currently, an item is only displayed if it starts with the typed text. In addition to that, I'd like to allow:
1) Abbreviation expansion; see first screnshot. This matches entries where the entered text matches the (beginning of) the camelCased or under_scored entry name's first letters.
2) Match if the entry only contains the word. This probably needs a bit of thinking to not disrupt existing workflows. My current solution only uses this filter if the length of the entered text is 4 or more characters.
What do you think?
Do you think this should be configurable?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/completion/katecompletionmodel.h <span style="color: grey">(088ac1988b0a591dc11466c4060d2c69196a544b)</span></li>
<li>part/completion/katecompletionmodel.cpp <span style="color: grey">(accd5e4adce12c7d2d4e7a69e4746d89d24bdf4a)</span></li>
<li>tests/codecompletiontestmodel.h <span style="color: grey">(c33a20004273149580659537dc1a7e5c6baec266)</span></li>
<li>tests/codecompletiontestmodel.cpp <span style="color: grey">(5d77c0478ce3956b016a35ce9c5a7b54798e2b83)</span></li>
<li>tests/completion_test.h <span style="color: grey">(0999fe144431677514876a2782c8acfddcdabe08)</span></li>
<li>tests/completion_test.cpp <span style="color: grey">(5bc4d2c8b7cbd06c17888cecf12ba076b3ec7c3d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112787/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/17/matching.png">abbreviation expansion</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/17/matching1.png">"contains" matching (if length > 3)</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>