<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112917/">http://git.reviewboard.kde.org/r/112917/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is awesome, thanks for your work :-)</pre>
<br />
<p>- Miquel Sabaté</p>
<br />
<p>On October 12th, 2013, 1:29 p.m. UTC, Heinz Wiesinger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Heinz Wiesinger.</div>
<p style="color: grey;"><i>Updated Oct. 12, 2013, 1:29 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-php
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add support for Trait declarations, as introduced in PHP 5.4.
This depends on https://git.reviewboard.kde.org/r/112916/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">make test, checked several example php files for correct parsing</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>completion/context.cpp <span style="color: grey">(d7bfd4ccec4206064ae56687057e235dbdca9dc8)</span></li>
<li>duchain/builders/contextbuilder.h <span style="color: grey">(18ed3900a10a7a26c0d3b71c0dc76a89f67046fe)</span></li>
<li>duchain/builders/contextbuilder.cpp <span style="color: grey">(7359ea2cc70ce1577f7189e0f1cdc1224b913f79)</span></li>
<li>duchain/builders/declarationbuilder.h <span style="color: grey">(e7f6f8cd0478bcaeae21ea39ae634881537d50be)</span></li>
<li>duchain/builders/declarationbuilder.cpp <span style="color: grey">(b5c813881cf94b376e173de200f476660d6c3b55)</span></li>
<li>duchain/builders/predeclarationbuilder.h <span style="color: grey">(344ea5324a9ba7f1aad085cacf8396bbef16312f)</span></li>
<li>duchain/builders/predeclarationbuilder.cpp <span style="color: grey">(bae6576c13c14b820e19a2ef384cbc0a12245dff)</span></li>
<li>parser/phplexer.cpp <span style="color: grey">(e17a54ff7fdff20fd35b4cff955dc228416b3ac8)</span></li>
<li>parser/php.g <span style="color: grey">(e07570fd495b14771c96b071f4d9865bad37f263)</span></li>
<li>duchain/tests/expressionparser.cpp <span style="color: grey">(26738120dd78b77371e1f89ad73974da6cdbcbc0)</span></li>
<li>duchain/tests/expressionparser.h <span style="color: grey">(16b2408925b46814c48f147d4e128cf08dba7594)</span></li>
<li>duchain/navigation/declarationnavigationcontext.cpp <span style="color: grey">(646b8695613a1f703b0dbb113d8cd674c20a2abd)</span></li>
<li>duchain/declarations/classdeclaration.cpp <span style="color: grey">(fbd69326781bb84c6115e944a1b518ef9cb516cf)</span></li>
<li>duchain/builders/typebuilder.h <span style="color: grey">(18375ed1bbd256a0faba51c1cb22a3c689ce2391)</span></li>
<li>duchain/builders/typebuilder.cpp <span style="color: grey">(6bcfa900ad67633a2c0ad0c422c370709126c379)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112917/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>