<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113092/">http://git.reviewboard.kde.org/r/113092/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113092/diff/1/?file=199153#file199153line40" style="color: black; font-weight: bold; text-decoration: underline;">plugins/documentview/kdevdocumentviewplugin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">40</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">K_EXPORT_PLUGIN</span><span class="p">(</span><span class="n">KDevDocumentViewFactory</span><span class="p">(</span><span class="n">KAboutData</span><span class="p">(</span><span class="s">"kdevdocumentview"</span><span class="p">,</span><span class="s">"kdevdocumentview"</span><span class="p">,</span> <span class="n">ki18n</span><span class="p">(</span><span class="s">"Document View"</span><span class="p">),</span> <span class="s">"0.1"</span><span class="p">,</span> <span class="n">ki18n</span><span class="p">(</span><span class="s">"<span class="hl">A list</span> of <span class="hl">opened documents</span>"</span><span class="p">),</span> <span class="n">KAboutData</span><span class="o">::</span><span class="n">License_GPL</span><span class="p">)))</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">40</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">K_EXPORT_PLUGIN</span><span class="p">(</span><span class="n">KDevDocumentViewFactory</span><span class="p">(</span><span class="n">KAboutData</span><span class="p">(</span><span class="s">"kdevdocumentview"</span><span class="p">,</span><span class="s">"kdevdocumentview"</span><span class="p">,</span> <span class="n">ki18n</span><span class="p">(</span><span class="s">"Document View"</span><span class="p">),</span> <span class="s">"0.1"</span><span class="p">,</span> <span class="n">ki18n</span><span class="p">(</span><span class="s">"<span class="hl">This plugin displays a graphical view</span> of <span class="hl">all documents currently loaded and separates them by mimetype.</span>"</span><span class="p">),</span> <span class="n">KAboutData</span><span class="o">::</span><span class="n">License_GPL</span><span class="p">)))</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd recommend not starting all descriptions with "This plugin...".
It's redundant.</pre>
</div>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On October 4th, 2013, 9:25 a.m. UTC, Meenakshi Khorana wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Meenakshi Khorana.</div>
<p style="color: grey;"><i>Updated Oct. 4, 2013, 9:25 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch for Bug 319011 - Difficult to view full plugin description
Improve plugin description(utilites and version control plugins), which is shown in the About dialog.
Reuse the wording from the .desktop file which is more helpful.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled and tested successfully on my local machine. Kdevelop is showing full description in About of Plugins.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/vcschangesview/vcschangesviewplugin.cpp <span style="color: grey">(7601b51)</span></li>
<li>plugins/switchtobuddy/switchtobuddyplugin.cpp <span style="color: grey">(d46334c)</span></li>
<li>plugins/snippet/snippetplugin.cpp <span style="color: grey">(e49310d)</span></li>
<li>plugins/konsole/kdevkonsoleviewplugin.cpp <span style="color: grey">(c018e19)</span></li>
<li>plugins/grepview/grepviewplugin.cpp <span style="color: grey">(53f466a)</span></li>
<li>plugins/externalscript/externalscriptplugin.cpp <span style="color: grey">(49db75a)</span></li>
<li>plugins/documentview/kdevdocumentviewplugin.cpp <span style="color: grey">(eb434b6)</span></li>
<li>plugins/codeutils/codeutilsplugin.cpp <span style="color: grey">(1afe512)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113092/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>