<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112787/">http://git.reviewboard.kde.org/r/112787/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 30th, 2013, 11:49 a.m. UTC, <b>Vlas Puhov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. Neither "contains" filtering nor abbreviation expansion works for UPPER_CASE_ENTRIES.
2. e.g. given entry: cursorPositionCoordinates
If I type position - everything is ok, but if add c: positionc - suggestion disappears, probably it shouldn't happen.
Otherwise it works great!!
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1 is a bit of a corner case, I'm not sure how we can support that in all obscure forms. Like upper_CAsE_eNTRIES, what do we do now? Does UCAE match this?
2 is a valid problem, the code I wrote now is a bit too simple to catch all cases. I'll update it shortly.</pre>
<br />
<p>- Sven</p>
<br />
<p>On September 29th, 2013, 12:18 p.m. UTC, Sven Brauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Kate and KDevelop.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated Sept. 29, 2013, 12:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">(I'll put this up here for discussion, I think a bit more work is required before submission.)
This patch implements less restrictive rules for completion list filtering. Currently, an item is only displayed if it starts with the typed text. In addition to that, I'd like to allow:
1) Abbreviation expansion; see first screnshot. This matches entries where the entered text matches the (beginning of) the camelCased or under_scored entry name's first letters.
2) Match if the entry only contains the word. This probably needs a bit of thinking to not disrupt existing workflows. My current solution only uses this filter if the length of the entered text is 4 or more characters.
What do you think?
Do you think this should be configurable?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/completion/katecompletionmodel.h <span style="color: grey">(088ac19)</span></li>
<li>part/completion/katecompletionmodel.cpp <span style="color: grey">(accd5e4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112787/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/17/matching.png">abbreviation expansion</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/17/matching1.png">"contains" matching (if length > 3)</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>