<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112039/">http://git.reviewboard.kde.org/r/112039/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Vlas Puhov.</div>
<p style="color: grey;"><i>Updated Sept. 8, 2013, 7:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">*Ported to model/view framework.
*Now all registers read/write.
*Distinguish general, float point and structured registers. The latter have different modes. Mode tells how to render given group i.e. how many columns it has and what value types in there (int, float...)
*Update only visible registers.
*Added shortcuts.
...
Updated screenshots.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a CPU registers toolview.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Supported architectures: x86/x86_64, arm v7(v6 should work too).
Features: All registers read/write. Structured registers can be represented in different modes(int64, int32, float,). Registers can be shown/set in different formats: bin, oct, dec, hex and unsigned.
Related changes:
DisassembleWidget: removed startAddress and endAddress combo boxes so as to let to resize disassemble view, but the change address functionality is still there through context menu.
FramestackModel: if first frame doesn't contain debug information don't set currentPosition to the first frame with debug information. It allows to keep synchronization between views(gdb, editor, disassemble widget and registers) otherwise all these views'll be in different states.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual only for x86/x86_64 and armv7 architectures </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=273152">273152</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debuggers/gdb/CMakeLists.txt <span style="color: grey">(32ef14f)</span></li>
<li>debuggers/gdb/debuggerplugin.cpp <span style="color: grey">(3533cdb)</span></li>
<li>debuggers/gdb/disassemblewidget.h <span style="color: grey">(81c25fc)</span></li>
<li>debuggers/gdb/disassemblewidget.cpp <span style="color: grey">(e1d6e8f)</span></li>
<li>debuggers/gdb/registers/converters.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>debuggers/gdb/registers/converters.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>debuggers/gdb/registers/modelsmanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>debuggers/gdb/registers/modelsmanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>debuggers/gdb/registers/registercontroller.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>debuggers/gdb/registers/registercontroller.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>debuggers/gdb/registers/registercontroller_arm.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>debuggers/gdb/registers/registercontroller_arm.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>debuggers/gdb/registers/registercontroller_x86.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>debuggers/gdb/registers/registercontroller_x86.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>debuggers/gdb/registers/registersmanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>debuggers/gdb/registers/registersmanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>debuggers/gdb/registers/registersview.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>debuggers/gdb/registers/registersview.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>debuggers/gdb/registers/registersview.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112039/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments (updated)</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/12/framestackmodel.diff">Related changes in kdevplatform</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/08/screensots.7z">Screensots</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>