<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112231/">http://git.reviewboard.kde.org/r/112231/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 23rd, 2013, 11:38 p.m. UTC, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good change! Just a few comments:
What I do not like is that we have buttons which have a dropdown menu with only one entry, and that twice (if we, as discussed (?) merge the "cancel jobs" action in Debug into "back to code"). I'd suggest to have a non-clickable label saying e.g. "<Icon> Review" and a button next to it titled "Back to code", and the menu only for the Code tab.
Then, sometimes the arrow for "Code" is still inside the text ...
And I think "Back to code" in Review must cancel the review mode. It's totally confusing to have this mode enabled outside of the Review area, since you have no idea how to turn it off. With this patch it becomes even less obvious how to turn it off.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the review!</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 23rd, 2013, 11:38 p.m. UTC, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112231/diff/1/?file=184251#file184251line225" style="color: black; font-weight: bold; text-decoration: underline;">shell/uicontroller.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">UiController::~UiController()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">225</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">UiController</span><span class="o">::</span><span class="n">setupActions</span><span class="p">()</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">225</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">UiController</span><span class="o">::</span><span class="n">setupActions</span><span class="p">()</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Empty method, do we need to keep it?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, all controllers have a setupActions, I'd say it's good to leave it empty.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 23rd, 2013, 11:38 p.m. UTC, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112231/diff/1/?file=184255#file184255line80" style="color: black; font-weight: bold; text-decoration: underline;">sublime/mainwindow.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void MainWindow::setupAreaSelector() {</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void MainWindow::setupAreaSelector()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">79</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">MainWindow</span><span class="o">::</span><span class="n">setupAreaSelector</span><span class="p">()</span><span class="hl"> </span><span class="p"><span class="hl">{</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">73</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">MainWindow</span><span class="o">::</span><span class="n">setupAreaSelector</span><span class="p">()</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Another empty method?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">:D remove more things!</pre>
<br />
<p>- Aleix</p>
<br />
<p>On August 23rd, 2013, 11:06 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Aug. 23, 2013, 11:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The area switching tabs is something that has bothered me quite a bit recently. It's something that is always visible in the screen and we barely use it. There's very little point to explicitly changing to an area, we usually do it from an action: debug, show differences, etc. These are specified by a new Area::addAction(QAction*) method.
This patch changes the current tab interface (inspired from Eclipse IIRC), for a button that tells the user what's the current area and where we can go.
The patch also removes the tabs and some unneeded abstractions in sublime/mainwindow that where only used by the tabs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Been using it for a couple of days, seems safe.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/CMakeLists.txt <span style="color: grey">(fe5cd9b)</span></li>
<li>shell/areadisplay.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/areadisplay.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/mainwindow.h <span style="color: grey">(2050219)</span></li>
<li>shell/mainwindow.cpp <span style="color: grey">(d4f4bcb)</span></li>
<li>shell/projectcontroller.cpp <span style="color: grey">(2186d90)</span></li>
<li>shell/runcontroller.cpp <span style="color: grey">(4a5a5e4)</span></li>
<li>shell/uicontroller.cpp <span style="color: grey">(2c0400f)</span></li>
<li>sublime/area.h <span style="color: grey">(878c120)</span></li>
<li>sublime/area.cpp <span style="color: grey">(df29ce3)</span></li>
<li>sublime/mainwindow.h <span style="color: grey">(96b9e71)</span></li>
<li>sublime/mainwindow.cpp <span style="color: grey">(f405200)</span></li>
<li>sublime/mainwindow_p.h <span style="color: grey">(7885d06)</span></li>
<li>sublime/mainwindow_p.cpp <span style="color: grey">(23c638d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112231/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/23/pairs-credits2.png">pairs-credits2.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/23/pairs-credits2_1.png">pairs-credits2_1.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/23/pairs-credits2_2.png">pairs-credits2_2.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>