<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111598/">http://git.reviewboard.kde.org/r/111598/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 1bf45f0cb2fe95bba2c5a8bc1e7f957d5f12c3b3 by Heinz Wiesinger to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 21st, 2013, 8:34 a.m. UTC, Heinz Wiesinger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Heinz Wiesinger.</div>
<p style="color: grey;"><i>Updated July 21, 2013, 8:34 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix the support for PHP 5.3's late static binding so that the 'static' keyword in
return static::property;
or
return static()
maps to the class it was declared in.
This is not 100% correct behavior, but since static is evaluated at runtime we can not determine at parsing what class type it really is.
However, it's always gonna be either the class it was declared in or one that extends the class it was declared in, so using that class as type should
provide better information than for example mixed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit test and example code.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=278085">278085</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>duchain/builders/typebuilder.cpp <span style="color: grey">(229c5c978b2bc77a2135a2b62c6ebf468e6d7b41)</span></li>
<li>duchain/expressionvisitor.cpp <span style="color: grey">(35f375a8f6f4a8e195b954548e01516c222f949b)</span></li>
<li>duchain/helper.cpp <span style="color: grey">(5628e10156d5b82d0beefcf8e65cda1f543a19eb)</span></li>
<li>duchain/tests/expressionparser.h <span style="color: grey">(9b3a561d2f2802545b3dbff4c127ae64441b9ef0)</span></li>
<li>duchain/tests/expressionparser.cpp <span style="color: grey">(9e76b0c7454fbf0f801816e006b9b273c43d141f)</span></li>
<li>parser/php.g <span style="color: grey">(34b4b671a3cec05b075adfc946dc3da110657b26)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111598/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>