<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111007/">http://git.reviewboard.kde.org/r/111007/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 16th, 2013, 8:56 a.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111007/diff/2/?file=150670#file150670line386" style="color: black; font-weight: bold; text-decoration: underline;">languages/cpp/tests/test_cppassistants.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">386</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Cpp</span><span class="o">::</span><span class="n">NavigationWidget</span> <span class="o">*</span><span class="n">macronavigationwidget</span> <span class="o">=</span> <span class="k">static_cast</span><span class="o"><</span><span class="n">Cpp</span><span class="o">::</span><span class="n">NavigationWidget</span><span class="o">*></span><span class="p">(</span><span class="n">macrowidget</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">use dynamic_cast here and below please, to get the extra testing functionality. Also QVERIFY(macroNavigationWidget)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">dynamic_cast is no possible with Cpp::MacroNavigationContext* somehow => leads to test_cppassistants.cpp:389: undefined reference to `typeinfo for Cpp::MacroNavigationContext</pre>
<br />
<p>- Hannes</p>
<br />
<p>On July 16th, 2013, 9:38 p.m. UTC, Hannes Hofer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Hannes Hofer.</div>
<p style="color: grey;"><i>Updated July 16, 2013, 9:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">when a macro is used that requires arguments and those arguments are split over multiple lines kdevelop is not able to expand the macro.
the expander respects only the current line and therefore the parser does not find the corresponding close brace.
in this fix the next line is added to the argument list until the close brace is found or EOF is reached.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">unit test included.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/cpp/tests/test_cppassistants.cpp <span style="color: grey">(42c7949)</span></li>
<li>languages/cpp/tests/test_cppassistants.h <span style="color: grey">(79fbb99)</span></li>
<li>languages/cpp/cpplanguagesupport.cpp <span style="color: grey">(e2ff0f1)</span></li>
<li>languages/cpp/cppduchain/navigation/macronavigationcontext.h <span style="color: grey">(eeaa9f6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111007/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>