<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111477/">http://git.reviewboard.kde.org/r/111477/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 10th, 2013, 10:52 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Like I said in the mailing list, I'd leave kdeprovider in kdeintegration...
Also it's better to create the patches with --find-copies-harder, so that moves reflect in the patch.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Aww. Looks like there was a misunderstanding about the KDE Provider plugin. Ok, I've updated the patch.</pre>
<br />
<p>- Miquel</p>
<br />
<p>On July 11th, 2013, 2:56 p.m. UTC, Miquel Sabaté wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Miquel Sabaté.</div>
<p style="color: grey;"><i>Updated July 11, 2013, 2:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In this review I'm adding the Github plugin that I've been working on in a scratch repo: http://quickgit.kde.org/?p=scratch%2Fmssola%2Fghprovider.git to the KDevelop repository. I've created the "providers" directory again, and I've put in there the KDE Provider plugin and this new Github plugin.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual testing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(8d2f8bb)</span></li>
<li>providers/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/README.md <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/cmake/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/cmake/FindQJson.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghaccount.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghaccount.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghdialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghdialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghlineedit.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghlineedit.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghprovidermodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghprovidermodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghproviderplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghproviderplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghproviderwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghproviderwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghresource.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghresource.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/icons/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/icons/hi16-app-github-forked.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/icons/hi16-app-github-private.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/icons/hi16-app-github-repo.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/icons/hi16-app-kdevgh.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/icons/hi32-app-kdevgh.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/kdevghprovider.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111477/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>