<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108213/">http://git.reviewboard.kde.org/r/108213/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good in principle - thanks!</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108213/diff/2/?file=166108#file166108line94" style="color: black; font-weight: bold; text-decoration: underline;">projectmanagers/custom-buildsystem/custombuildsystemconfigwidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void CustomBuildSystemConfigWidget::loadFrom( KConfig* cfg )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">94</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">tool</span><span class="p">.</span><span class="n">envGrp</span> <span class="o">=</span> <span class="n">toolgrp</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span> <span class="n">ConfigConstants</span><span class="o">::</span><span class="n">toolEnvironment</span><span class="p">,</span> <span class="s">"<span class="hl">default</span>"</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">94</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">tool</span><span class="p">.</span><span class="n">envGrp</span> <span class="o">=</span> <span class="n">toolgrp</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span> <span class="n">ConfigConstants</span><span class="o">::</span><span class="n">toolEnvironment</span><span class="p">,</span> <span class="s">""</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Here and above/below: QString() instead of ""?</pre>
</div>
<br />
<p>- Milian</p>
<br />
<p>On June 27th, 2013, 12:58 p.m. UTC, Ivan Shapovalov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Ivan Shapovalov.</div>
<p style="color: grey;"><i>Updated June 27, 2013, 12:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A follow-up to https://git.reviewboard.kde.org/r/108212/.
This removes calls to addItems() and uses "" instead of "default" as default config values.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual testing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectmanagers/custom-buildsystem/custombuildsystemconfigwidget.cpp <span style="color: grey">(6934c43)</span></li>
<li>projectmanagers/custom-buildsystem/configwidget.cpp <span style="color: grey">(bcd85c5)</span></li>
<li>projectmanagers/cmake/settings/cmakepreferences.cpp <span style="color: grey">(c309fef)</span></li>
<li>projectbuilders/makebuilder/makejob.cpp <span style="color: grey">(1a8c2ce)</span></li>
<li>projectbuilders/makebuilder/makeconfig.ui <span style="color: grey">(592bba3)</span></li>
<li>projectbuilders/makebuilder/makebuilderpreferences.cpp <span style="color: grey">(5ffceb6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108213/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>