<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111347/">http://git.reviewboard.kde.org/r/111347/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 3bddbafad8c47d23b37afb1b3268d6f2277dfecd by Kevin Funk on behalf of Ben Wagner to branch 4.5.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 1st, 2013, 5:48 p.m. UTC, Ben Wagner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Ben Wagner.</div>
<p style="color: grey;"><i>Updated July 1, 2013, 5:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">MissingIncludeCompletionWorker::computeCompletions causes an overloaded-virtual warning when building kdevelop. Upon investigation, it appears that it was intended to override CodeCompletionWorker::computeCompletions, but the third parameter is incorrect.
KDevelop was crashing left and right and with this change seems a bit more stable.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built, ran. Verified that this overloaded-virtual warning no longer occurs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/cpp/codecompletion/missingincludemodel.h <span style="color: grey">(7c5673e)</span></li>
<li>languages/cpp/codecompletion/missingincludemodel.cpp <span style="color: grey">(346e8a1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111347/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/07/01/0001-Fix-overloaded-virtual-of-computeCompletions.patch">git format-patch</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>