<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103904/">http://git.reviewboard.kde.org/r/103904/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 31st, 2013, 1:07 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I see in bugzilla that this was reverted because it required a too new version of kdelibs. Should we maybe revise it?</pre>
</blockquote>
<p>On May 3rd, 2013, 9:19 p.m. UTC, <b>Ghislain Mary</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">http://techbase.kde.org/KDevelop4/Compatibility tells that KDevelop 4.2 and later versions require at least kdelibs 4.5.2.
But it seems this page is not really up-to-date. So what is the minimum kdelibs requirement for KDevelop 4.5?</pre>
</blockquote>
<p>On May 3rd, 2013, 9:46 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Are you having problems with 4.5? Which ones?</pre>
</blockquote>
<p>On May 3rd, 2013, 10:06 p.m. UTC, <b>Ghislain Mary</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No problem, it's just to know if KMessageWidget can now be used in kdevplatform since this patch was reverted because KMessageWidget was introduced in kdelibs 4.7 and KDevelop needed to be compilable with kdelibs 4.5.2 at the time the patch was submitted.</pre>
</blockquote>
<p>On May 3rd, 2013, 10:32 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wouldn't oppose to change the kdelibs dependency to kde 4.7.
Also we probably can use KMessageWidget in other places as well.
Debian wheezy (the stable as of really soon) has KDE 4.8 anyway.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Note: We already use KMessageWidget in plugins/filetemplates (introduced Dec, 2012)</pre>
<br />
<p>- Kevin</p>
<br />
<p>On February 10th, 2012, 11:44 a.m. UTC, Ghislain Mary wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Ghislain Mary.</div>
<p style="color: grey;"><i>Updated Feb. 10, 2012, 11:44 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Show a warning message in a KMessageWidget if a space character is entered in the snippet name line edit.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=274299">274299</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/snippet/editsnippet.cpp <span style="color: grey">(732c52a71967ff6d2eea131f854d92f3f2b19ccf)</span></li>
<li>plugins/snippet/editsnippet.ui <span style="color: grey">(bb48e5e8570e37e2b53a2b69971d76ee201f0742)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103904/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2012/02/10/0001-Bug-274299-JJ-explanation-on-failed-snippet-name-val.patch">Patch created with "git format-patch" and with wording fix</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>