<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110107/">http://git.reviewboard.kde.org/r/110107/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 21st, 2013, 8:44 p.m. UTC, <b>David Nolden</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I see another slight problem when I see the huge array of working-set icons: Together they form a strange combined pattern in my brain, similar to rails.
I would propose to randomly rotate each rectangle slighty (but deterministically), like the folder-previews in the dolphin browser. A large random angle would even make them much more distiguishable, but it also shouldn't look too chaotic, so it would have to be balanced.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm. Do you think that will be a problem for the two or three working-sets you usually have? What I got in the screenshot there is a pretty unrealistic example, isn't it?
Rotating the rectangles will be difficult, because the icon is so small... the spacing between the rectangles is just 2 pixels, so if you rotate each rect by just one pixel, they already touch or intersect, which will probably look quite bad. If you want to see it I can try implementing it, but I expect it won't be very good. I have choosen the "straight rectangle" pattern on purpose, since it looks very clean in that small size.</pre>
<br />
<p>- Sven</p>
<br />
<p>On April 21st, 2013, 6:26 p.m. UTC, Sven Brauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated April 21, 2013, 6:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently each working set gets a random icon from some application, which looks very weird. For example, it used the alarm function icon, and did lots of things like desaturate it, which in the end made everything look very confusing and messy in my opinion.
This patch instead replaces the icons by colored dots, inspired by konversation's default nicklist icons. They are easy to differentiate, look clean, and are not associated with totally different things by the user.
Additionally, the new icons are generated at run-time, and are completely calculated from the working set's ID. Thus, lots of messy code which iterates through possible icons, checks if they're already being used, saves them to a config file, loads them from a config file etc. was removed. Of course this comes at the price of painting the new icons, but the code doing that is contained in one single, obvious function and not splattered around everywhere. Also, the icons are no longer involved in deciding which working sets should be loaded on startup (sic).
It could be discussed if the icon could still be improved optically, especially I don't like the blue vs. darkgrey contrast too much -- suggestions are welcome!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manually tested creating and removing working sets in various conditions, and also tested closing and re-opening kdevelop with various working set setups. Seems okay.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/workingsets/workingsettoolbutton.cpp <span style="color: grey">(c890049)</span></li>
<li>shell/workingsets/workingset.cpp <span style="color: grey">(cac0d54)</span></li>
<li>shell/workingsets/workingset.h <span style="color: grey">(ae2aa94)</span></li>
<li>shell/workingsetcontroller.cpp <span style="color: grey">(3b4f90c)</span></li>
<li>shell/workingsetcontroller.h <span style="color: grey">(9697a99)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110107/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/20/workingsets.png">old workingset icons</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/20/workingsets_new.png">new workingset icons</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/21/workingsets_dark.png">workingsets_dark.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/21/workingseticons1.png">workingseticons1.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>