<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109829/">http://git.reviewboard.kde.org/r/109829/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Alexander Dymo.</div>
<div>By Aleix Pol Gonzalez.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I had been hitting some ugly bug recently, where KDevelop would initialize in a weird state where one of the docks was shown but the button wasn't checked, so I had to press the button to hide it (hotkeys didn't work).
I decided to investigate when were the hidden toolviews shown. gdb soon suggested it was in restoreState(). I started to fiddle with the code to see what could be wrong, but I couldn't manage to find out, so I tried to disable it. It worked (surprisingly good I must add, most of the glitches I had when changing areas are gone with this change).
This is not a proper review request, but I was wondering what are we trying to restore there. Toolviews and menues are managed elsewhere, so are the document views. The size isn't being restored there either (load/saveGeometry).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All tests pass (but testgenerationtest), didn't add any other test.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>sublime/mainwindow.cpp <span style="color: grey">(9d55ca6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109829/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>