<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109776/">http://git.reviewboard.kde.org/r/109776/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109776/diff/1/?file=125700#file125700line26" style="color: black; font-weight: bold; text-decoration: underline;">app/splash.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setWindowFlags</span><span class="p">(</span><span class="n">f</span> <span class="o">|</span> <span class="n">Qt</span><span class="o">::</span><span class="n">WindowStaysOnTopHint</span> <span class="o">|</span> <span class="n">Qt</span><span class="o">::</span><span class="n">FramelessWindowHint</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setWindowFlags</span><span class="p">(</span><span class="n">f</span><span class="hl"> </span><span class="o"><span class="hl">|</span></span><span class="hl"> </span><span class="n"><span class="hl">Qt</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">SplashScreen</span></span> <span class="o">|</span> <span class="n">Qt</span><span class="o">::</span><span class="n">WindowStaysOnTopHint</span> <span class="o">|</span> <span class="n">Qt</span><span class="o">::</span><span class="n">FramelessWindowHint</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the bug is that this line overwrites the default window flags. The proper fix is quite probably to either remove it alltogether as QSplashScreen already sets Qt::SplashScreen | Qt::FramelessWindowHint or - if the WindowStaysOnTopHint is required, do it like this:
in the member initializer list, do
: KSplashScreen(pixmap, f | Qt::WindowStaysOnTopHint)</pre>
</div>
<br />
<p>- Milian</p>
<br />
<p>On March 28th, 2013, 11:46 a.m. UTC, Marcel Hellwig wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Marcel Hellwig.</div>
<p style="color: grey;"><i>Updated March 28, 2013, 11:46 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The new splash screen does not set the _NET_WM_WINDOW_TYPE to _NET_WM_WINDOW_TYPE_SPLASH, although it should be as it is mentioned in QSplashScreen. It's annoying in s twm (i3).
As a "proof" here is a xprop extract.
before:
WM_STATE(WM_STATE):
window state: Normal
icon window: 0x0
_NET_WM_STATE(ATOM) = _NET_WM_STATE_ABOVE, _NET_WM_STATE_STAYS_ON_TOP
_NET_WM_WINDOW_TYPE(ATOM) = _KDE_NET_WM_WINDOW_TYPE_OVERRIDE, _NET_WM_WINDOW_TYPE_NORMAL
_MOTIF_WM_HINTS(_MOTIF_WM_HINTS) = 0x3, 0x4, 0x0, 0x0, 0x0
WM_PROTOCOLS(ATOM): protocols WM_DELETE_WINDOW, WM_TAKE_FOCUS, _NET_WM_PING, _NET_WM_SYNC_REQUEST
WM_NAME(STRING) = "kdevelop"
WM_LOCALE_NAME(STRING) = "en_US.utf8"
WM_CLASS(STRING) = "kdevelop", "Kdevelop"
WM_HINTS(WM_HINTS):
Client accepts input or input focus: True
Initial state is Normal State.
bitmap id # to use for icon: 0x3400014
window id # of group leader: 0x3400004
WM_NORMAL_HINTS(WM_SIZE_HINTS):
user specified location: 563, 300
program specified location: 563, 300
user specified size: 475 by 301
program specified size: 475 by 301
program specified minimum size: 475 by 301
program specified maximum size: 475 by 301
window gravity: Static
WM_COMMAND(STRING) = { "kdevelop" }
after:
WM_STATE(WM_STATE):
window state: Normal
icon window: 0x0
_NET_WM_SYNC_REQUEST_COUNTER(CARDINAL) = 54525975
_NET_WM_STATE(ATOM) = _NET_WM_STATE_ABOVE, _NET_WM_STATE_STAYS_ON_TOP
WM_TRANSIENT_FOR(WINDOW): window id # 0x3400004
WM_CLIENT_LEADER(WINDOW): window id # 0x3400004
_NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_SPLASH, _KDE_NET_WM_WINDOW_TYPE_OVERRIDE, _NET_WM_WINDOW_TYPE_NORMAL
WM_PROTOCOLS(ATOM): protocols WM_DELETE_WINDOW, WM_TAKE_FOCUS, _NET_WM_PING, _NET_WM_SYNC_REQUEST
WM_NAME(STRING) = "kdevelop"
WM_LOCALE_NAME(STRING) = "en_US.utf8"
WM_CLASS(STRING) = "kdevelop", "Kdevelop"
WM_HINTS(WM_HINTS):
Client accepts input or input focus: True
Initial state is Normal State.
bitmap id # to use for icon: 0x3400014
window id # of group leader: 0x3400004
WM_NORMAL_HINTS(WM_SIZE_HINTS):
user specified location: 563, 300
program specified location: 563, 300
user specified size: 475 by 301
program specified size: 475 by 301
program specified minimum size: 475 by 301
program specified maximum size: 475 by 301
window gravity: NorthWest
WM_COMMAND(STRING) = { "kdevelop" }
I think this is a bug in QSplashScreen but I don't know and this fix it for me.
Regards</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual testing done. It will now be displayed properly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/splash.cpp <span style="color: grey">(5e932c2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109776/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>